Resolve node-fetch@^2.3.0 to 2.6.7 to fix security vulnerability GHSA-r683-j2x4-v87g #1198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonny133
changed the title
|
Hello @orta Coul be merged this PR and launch a new release? Thanks. |
|
Yep 👍🏻 |
|
This PR removes node-fetch from the deps, given that we use it - that does not seem like the right answer |
|
Strange, it did merge but the PR is still open, so I'll manually close |
|
OK, that's shipped in 10.9.0 |
glensc
pushed a commit
to glensc/danger-js
that referenced
this pull request
Mar 16, 2022
Resolve node-fetch@^2.3.0 to 2.6.7 to fix security vulnerability GHSA-r683-j2x4-v87g
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve
node-fetch@^2.3.0to2.6.7to fix GHSA-r683-j2x4-v87gRemoved from
package.jsonas it did not preventnode-fetch@^2.3.0resolving2.3.0and is not necessary now.Update the types to latest 2.x as well