New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate Danger Run into two processes #395

Merged
merged 14 commits into from Oct 22, 2017

Conversation

Projects
None yet
2 participants
@orta
Member

orta commented Oct 16, 2017

Moves the JavaScript runner to also work in the same method as danger process. The idea is that we can use process separation even inside the JavaScript client built into Danger JS. ( see the docs if this is new to you ) which means new features to DangerJS will definitely improve anyone using Danger in their own language.

This process separation will work with danger/peril#159 to solidify the idea of separation for Peril and the runner (on lambda.)

TODO:

  • Convert danger to actually be danger process "danger runner" basically
  • The DSL needs to have functions added back into it, e.g. git.utils, github.utils, github.api
  • Use the runner to run fixtures DSL data agains the JS files inside the runner's fixtures
@orta

This comment has been minimized.

Member

orta commented Oct 21, 2017

OK, this is now green in terms of the biggest refactorings 👍

@orta

This comment has been minimized.

Member

orta commented Oct 21, 2017

CI now runs every example dangerfile through danger-runner - see travis' node 8.4

screen shot 2017-10-21 at 5 02 02 pm

@orta

This comment has been minimized.

Member

orta commented Oct 21, 2017

Only the conversion of danger [args] to danger process 'danger runner [args]' to go

@DangerCI

This comment has been minimized.

DangerCI commented Oct 22, 2017

Warnings
⚠️

this worked

Generated by 🚫 dangerJS

orta added some commits Oct 22, 2017

@orta orta changed the title from Initial work on adding a danger-process style runner for JS to Separate Danger Run into two processes Oct 22, 2017

@orta orta merged commit cbc8252 into master Oct 22, 2017

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@orta orta deleted the convert_danger_to_danger_process branch Oct 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment