Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt emoji for Bitbucket server to fix "Database error has occurred" #645

Merged
merged 5 commits into from Aug 1, 2018

Conversation

Projects
None yet
2 participants
@acecilia
Copy link
Member

acecilia commented Aug 1, 2018

Bitbucket server only supports emojis in recent versions. For example, Bitbucket v4.10.1 does not support them, and when commenting with them the server returns an error saying "Database error has occurred".

Implementation similar to danger/danger@638943d#diff-4b908d596ce5ef33cce2a524a5694a4f

acecilia added some commits Aug 1, 2018

const fullDiff = danger.git.diffForFile('foo.js')
const addedLines = danger.git.diffForFile('foo.js', ['add'])
const removedLines = danger.git.diffForFile('foo.js', ['del'])
const fullDiff = danger.git.diffForFile("foo.js")

This comment has been minimized.

@acecilia

acecilia Aug 1, 2018

Author Member

I did not add this changes, I think the hooks that the project has are causing this.

This comment has been minimized.

@orta

orta Aug 1, 2018

Member

cool 👍

@orta

orta approved these changes Aug 1, 2018

Copy link
Member

orta left a comment

cool, looks good 0- thanks

const fullDiff = danger.git.diffForFile('foo.js')
const addedLines = danger.git.diffForFile('foo.js', ['add'])
const removedLines = danger.git.diffForFile('foo.js', ['del'])
const fullDiff = danger.git.diffForFile("foo.js")

This comment has been minimized.

@orta

orta Aug 1, 2018

Member

cool 👍

${results.messages.map(printViolation("📖")).join("\n")}
${results.fails.map(printViolation(noEntryEmoji)).join("\n")}
${results.warnings.map(printViolation(warningEmoji)).join("\n")}
${results.messages.map(printViolation(messageEmoji)).join("\n")}

This comment has been minimized.

@orta

orta Aug 1, 2018

Member

Yep - this all makes sense 👍

@@ -13,6 +13,11 @@

## Master

# 3.8.3

This comment has been minimized.

@orta

orta Aug 1, 2018

Member

Adding this means likely merge conflicts, best to leave them next time - I normally add this version when I create the new release. I should make a danger rule for that 👍

This comment has been minimized.

@acecilia

acecilia Aug 1, 2018

Author Member

I can avoid adding changelog for the next PR. Do you prefer that? Or just add the changelog without specifying the version?

@orta orta merged commit a6e6b66 into danger:master Aug 1, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@peril-staging

This comment has been minimized.

Copy link
Contributor

peril-staging bot commented Aug 1, 2018

Thanks for the PR @acecilia.

This PR has been shipped in v3.8.3 - CHANGELOG.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.