Bitbucket fixes #646
Merged
Bitbucket fixes #646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
acecilia
commented
Aug 1, 2018
acecilia
commented
- Fix error when trying to obtain a response json when the response code is 204 (which means that there is no response)
- Fix link of the PR status, so it opens the web version of the PR, pointing to the Danger comment
…nting to the Danger comment
…e is 204 (which means that there is no response)
acecilia
commented
Aug 1, 2018
| - Fix error when trying to obtain a response json when the response code is 204 (which means that there is no response). | ||
| Fix link of the PR status, so it opens the web version of the PR, pointing to the Danger comment | ||
| [646](https://github.com/danger/danger-js/pull/646) - [@acecilia](https://github.com/acecilia) | ||
|
|
Member
Author
There was a problem hiding this comment.
The hooks that the project has are putting each of the sentences here in a new line
Member
There was a problem hiding this comment.
No worries, if they are different fixes then they can be different line items, I’ll fix it pre shipping
Member
|
Yep, cool, merge on green |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.