Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bitbucket fixes #646

Merged
merged 6 commits into from Aug 1, 2018
Merged

Bitbucket fixes #646

merged 6 commits into from Aug 1, 2018

Conversation

acecilia
Copy link
Member

@acecilia acecilia commented Aug 1, 2018

  • Fix error when trying to obtain a response json when the response code is 204 (which means that there is no response)
  • Fix link of the PR status, so it opens the web version of the PR, pointing to the Danger comment

CHANGELOG.md Outdated
- Fix error when trying to obtain a response json when the response code is 204 (which means that there is no response).
Fix link of the PR status, so it opens the web version of the PR, pointing to the Danger comment
[646](https://github.com/danger/danger-js/pull/646) - [@acecilia](https://github.com/acecilia)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hooks that the project has are putting each of the sentences here in a new line

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries, if they are different fixes then they can be different line items, I’ll fix it pre shipping

@orta
Copy link
Member

orta commented Aug 1, 2018

Yep, cool, merge on green

@peril-staging peril-staging bot merged commit 7b5c193 into danger:master Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants