Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bitbucket fixes #646

Merged
merged 6 commits into from Aug 1, 2018
Merged
Diff settings

Always

Just for now

Copy path View file
@@ -13,6 +13,12 @@

## Master

# 3.8.3

- Fix error when trying to obtain a response json when the response code is 204 (which means that there is no response).
Fix link of the PR status, so it opens the web version of the PR, pointing to the Danger comment
[646](https://github.com/danger/danger-js/pull/646) - [@acecilia](https://github.com/acecilia)

This comment has been minimized.

Copy link
@acecilia

acecilia Aug 1, 2018

Author Member

The hooks that the project has are putting each of the sentences here in a new line

This comment has been minimized.

Copy link
@orta

orta Aug 1, 2018

Member

No worries, if they are different fixes then they can be different line items, I’ll fix it pre shipping

# 3.8.2

- Use the Peril Bot ID for the comment lookup checks - [@orta][]
@@ -232,8 +232,8 @@ export class BitBucketServer implements Platform {
// So take the PR and attack the comment, I think :D

const host = this.api.repoCredentials.host
const prURL = this.api.getPRBasePath()
return issue && issue.id && `${host}${prURL}/diff#comment-${issue.id}`
const { repoSlug, pullRequestID } = this.api.repoMetadata
return issue && issue.id && `${host}/${repoSlug}/pull-requests/${pullRequestID}/overview?commentId=${issue.id}`
}

getFileContents = this.api.getFileContents
@@ -181,7 +181,10 @@ export class BitBucketServerAPI {
) => {
const res = await this.post(`rest/build-status/1.0/commits/${commitId}`, {}, payload)
throwIfNotOk(res)
return await res.json()
// If the response status does not contain anything (error code === 204), do not return anything. Otherwise return the json response (seems like bitbucket server v4.10.1 returns 204 with empty response after setting the status)
if (res.status !== 204) {
return await res.json()
}
}

postPRComment = async (comment: string) => {
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.