Prevent GitHub adding a <p> tag to <td> inside issue comment. #754
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for this awesome project. It looks awesome! There was one thing that caught my attention; the vertical alignment of content in the table seemed somewhat off.
Before:

After:

This PR fixes that.
After comparing the implementation and the code that GitHub renders. I found that the GitHub markdown implementation adds an
tag inside the when it thinks the text should be a text block (because of the linebreak before and after
${message}
). When it appends a<p>
the user-agent add the default margin at the bottom of the paragraph. (as an example; chrome adds margin-bottom: 16px;) This messes up the vertical alignment.I removed the linebreaks and github andeverything seems to render everything correctly.
HTML output by github:
Before:

After:

Important: I also updated the
githubIssueTemplates.test.ts.snap
snapshot reflect the changes.PS. @orta I am sure this is not the right way but I wanted to thank you and the artsy crew for the inspiring talks @facebookHQ in london last July.