Prevent GitHub adding a <p> tag to <td> inside issue comment.

[patrickkempff]

Thanks for this awesome project. It looks awesome! There was one thing that caught my attention; the vertical alignment of content in the table seemed somewhat off.

Before:

After:

This PR fixes that.

After comparing the implementation and the code that GitHub renders. I found that the GitHub markdown implementation adds an

tag inside the when it thinks the text should be a text block (because of the linebreak before and after ${message}). When it appends a <p> the user-agent add the default margin at the bottom of the paragraph. (as an example; chrome adds margin-bottom: 16px;) This messes up the vertical alignment.

I removed the linebreaks and github andeverything seems to render everything correctly.

HTML output by github:

Before:

After:

Important: I also updated the githubIssueTemplates.test.ts.snap snapshot reflect the changes.

PS. @orta I am sure this is not the right way but I wanted to thank you and the artsy crew for the inspiring talks @facebookHQ in london last July.

[orta]

Hrm, part of me feels like this is intentional (otherwise why would it be so weird?) - let's give it a shot anyway, and see what happens.

[peril-staging]

Thanks for the PR @patrickkempff.

The Danger org conform to the Moya Community Continuity Guidelines, which means
that we want to offer any contributor the ability to control their destiny.

So, we've sent you an org invite - thanks patrickkempff 🎉

Generated by 🚫 dangerJS

[patrickkempff]

Hrm, part of me feels like this is intentional (otherwise why would it be so weird?) - let's give it a shot anyway, and see what happens.

After some searching around I found an commit from 2 years ago by @macklinu.
This discussion seems to be related: #240 (comment). I am not sure if it is still relevant

[orta]

It probably is, I wonder if maybe we will need to do multi-line detection or something like that to make sure it handles inline html

[macklinu]

I wonder if the <p> tag had something to do with Markdown formatting within a table cell? Something I noticed in the before/after of the PR screenshot:

This definitely looks cleaner without the extra <p> tag, so if there's a good way to support inline markdown with this too, I'm all for it. 👍

[patrickkempff]

@orta maybe we should revert this PR until we have a better solution handling both cases. What do you think?

[orta]

It's not shipped yet, so maybe we can look to see if the string includes a few particular chars and just include that?

[patrickkempff]

Markdown regression is fixed in #777