Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upConversation
langovoi
requested a review
from
orta
Nov 14, 2018
This comment has been minimized.
This comment has been minimized.
|
@orta could you review, please? |
| values = values.concat(data.values) | ||
| nextPageStart = data.nextPageStart | ||
| } while (nextPageStart !== null) |
This comment has been minimized.
This comment has been minimized.
| @@ -3,7 +3,7 @@ import { dangerSignaturePostfix } from "../../../runner/templates/bitbucketServe | ||
| describe("API testing - BitBucket Server", () => { | ||
| let api: BitBucketServerAPI | ||
| let jsonResult: any | ||
| let jsonResult: () => any |
This comment has been minimized.
This comment has been minimized.
langovoi
Nov 14, 2018
Contributor
Allowing to set jsonResult as function. For example for use jest.fn
| nextPageStart: 1, | ||
| values: ["1"], | ||
| }) | ||
| .mockReturnValueOnce({ |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
OK, cool, yeah this looks good |
orta
merged commit 0afefa8
into
danger:master
Nov 15, 2018
langovoi
deleted the
langovoi:bitbucket-diff
branch
Nov 15, 2018
This comment has been minimized.
This comment has been minimized.
|
Great! Could you make new release, please? |
This comment has been minimized.
This comment has been minimized.
|
Yep, this came out in 6.1.4 |
This comment has been minimized.
This comment has been minimized.
|
@langovoi Am I misunderstanding something or are you missing the At the firm I work at we are getting |
This comment has been minimized.
This comment has been minimized.
|
Oh..sure, |
This comment has been minimized.
This comment has been minimized.
|
Could you make PR? |
This comment has been minimized.
This comment has been minimized.
|
Yeah, sure. I will have a try when I get home! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
langovoi commentedNov 14, 2018
•
edited
Bitbucket Server API for
diffsometimes returntruncated: truein root of response.This means that Bitbucket Server don't provide full diff of all files.
In my practical with Danger, this breaks
modified_files,created_filesanddeleted_files.Bitbucket Server has another API, which returns list of changes in PR, without diff.
I replaced
diffAPI withchangesAPI for generationGitJSONDSL.Also I reworked
diffForFileto fix potential bug with Bitbucket Server, whendiffAPI may return truncated results.