New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the Commit Lint plugin #93

Merged
merged 1 commit into from Aug 26, 2016

Conversation

Projects
None yet
3 participants
@jonallured
Contributor

jonallured commented Aug 26, 2016

I think it's a good one! What was once 5 lines of Ruby in a Dangerfile is now over 450 lines of code in the form of a well-tested and documented gem.

Am I doing this right?? 馃榾 馃榾 馃榾

Check it: https://github.com/jonallured/danger-commit_lint

Adds the Commit Lint plugin
I think it's a good one! What was once 5 lines of Ruby is now over 450
lines of code in the form of a well-tested and documented gem. I think
that's good? 馃槙

Check it: https://github.com/jonallured/danger-commit_lint
@DangerCI

This comment has been minimized.

Show comment
Hide comment
@DangerCI

DangerCI Aug 26, 2016

Failed to parse danger-commit_lint

commit_lint

Run each commit in the PR through a message linting.

Lint all commits using defaults
commit_lint.check
Warn instead of fail
commit_lint.check warn: :all
Disable a particular check
commit_lint.check disable: [:subject_period]

Methods

check - Checks the commits with whatever config the user passes.


Generated by 馃毇 danger

Failed to parse danger-commit_lint

commit_lint

Run each commit in the PR through a message linting.

Lint all commits using defaults
commit_lint.check
Warn instead of fail
commit_lint.check warn: :all
Disable a particular check
commit_lint.check disable: [:subject_period]

Methods

check - Checks the commits with whatever config the user passes.


Generated by 馃毇 danger

@jonallured

This comment has been minimized.

Show comment
Hide comment
@jonallured

jonallured Aug 26, 2016

Contributor

Hmmm, I'm green when I run bundle exec danger plugins lint on my machine - what am I missing??

Contributor

jonallured commented Aug 26, 2016

Hmmm, I'm green when I run bundle exec danger plugins lint on my machine - what am I missing??

@orta

This comment has been minimized.

Show comment
Hide comment
@orta

orta Aug 26, 2016

Member

This bit is wrong in the Dangerfile: markdown "### Failed to parse #{plugin}" if $0 != 0 it should be unless $0.success? the $0 does not represent the error code, but an object, so it always fails

Member

orta commented Aug 26, 2016

This bit is wrong in the Dangerfile: markdown "### Failed to parse #{plugin}" if $0 != 0 it should be unless $0.success? the $0 does not represent the error code, but an object, so it always fails

@orta

This comment has been minimized.

Show comment
Hide comment
@orta

orta Aug 26, 2016

Member

So this is almost perfect - ideally, I'd love to see your usage section move into the comments above the class, so that you know what the checks are by just looking at the overview we see above ( which is what'll show on the site. )

Right now you don't know what it's going to check for without going to a different repo - which ideally can get fixed in the next release - other than that, this looks awesome!

Member

orta commented Aug 26, 2016

So this is almost perfect - ideally, I'd love to see your usage section move into the comments above the class, so that you know what the checks are by just looking at the overview we see above ( which is what'll show on the site. )

Right now you don't know what it's going to check for without going to a different repo - which ideally can get fixed in the next release - other than that, this looks awesome!

@orta orta merged commit 1d27241 into danger:master Aug 26, 2016

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
@orta

This comment has been minimized.

Show comment
Hide comment
@orta

orta Aug 26, 2016

Member

Great job 馃憤

Member

orta commented Aug 26, 2016

Great job 馃憤

@jonallured jonallured referenced this pull request Aug 26, 2016

Merged

Fix Dangerfile #95

@jonallured

This comment has been minimized.

Show comment
Hide comment
@jonallured

jonallured Aug 26, 2016

Contributor

Yeah, I think it'll really help to see this on the site and then I can tweak it from there. 鉂わ笍 鉂わ笍 鉂わ笍

Contributor

jonallured commented Aug 26, 2016

Yeah, I think it'll really help to see this on the site and then I can tweak it from there. 鉂わ笍 鉂わ笍 鉂わ笍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment