From 1839ce322b88addf00eda236e9a3ab050bedc94e Mon Sep 17 00:00:00 2001 From: ydah Date: Mon, 15 Apr 2024 11:39:43 +0900 Subject: [PATCH 1/7] accrodingly ==> accordingly --- spec/lib/danger/commands/runner_spec.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spec/lib/danger/commands/runner_spec.rb b/spec/lib/danger/commands/runner_spec.rb index 43c48c496..ebe9a5b01 100644 --- a/spec/lib/danger/commands/runner_spec.rb +++ b/spec/lib/danger/commands/runner_spec.rb @@ -16,7 +16,7 @@ end context "default options" do - it "sets instance variables accrodingly" do + it "sets instance variables accordingly" do argv = CLAide::ARGV.new([]) runner = described_class.new(argv) From fa558612ccbde2a5d0f9a8b7a9b5f09c9a8119aa Mon Sep 17 00:00:00 2001 From: ydah Date: Mon, 15 Apr 2024 11:40:12 +0900 Subject: [PATCH 2/7] ingores ==> ignores --- spec/lib/danger/request_sources/github_spec.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/spec/lib/danger/request_sources/github_spec.rb b/spec/lib/danger/request_sources/github_spec.rb index 77edf20c9..d69d41deb 100644 --- a/spec/lib/danger/request_sources/github_spec.rb +++ b/spec/lib/danger/request_sources/github_spec.rb @@ -500,7 +500,7 @@ @g.update_pull_request!(warnings: [], errors: [], messages: [v]) end - it "ingores out of range inline comments when in dismiss mode" do + it "ignores out of range inline comments when in dismiss mode" do allow(@g.client).to receive(:pull_request_comments).with("artsy/eigen", "800").and_return([]) expect(@g.client).not_to receive(:create_pull_request_comment).with("artsy/eigen", "800", anything, "561827e46167077b5e53515b4b7349b8ae04610b", "CHANGELOG.md", 10) @@ -515,7 +515,7 @@ @g.update_pull_request!(warnings: [], errors: [], messages: [v]) end - it "ingores out of range inline comments when in dismiss mode per kind" do + it "ignores out of range inline comments when in dismiss mode per kind" do allow(@g.client).to receive(:pull_request_comments).with("artsy/eigen", "800").and_return([]) expect(@g.client).to receive(:create_pull_request_comment).with("artsy/eigen", "800", anything, "561827e46167077b5e53515b4b7349b8ae04610b", "CHANGELOG.md", 4) From 13a5b716d2af7056363b6a512d5879561c7f885c Mon Sep 17 00:00:00 2001 From: ydah Date: Mon, 15 Apr 2024 11:40:34 +0900 Subject: [PATCH 3/7] nonexistant ==> nonexistent --- spec/lib/danger/commands/local_helpers/pry_setup_spec.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spec/lib/danger/commands/local_helpers/pry_setup_spec.rb b/spec/lib/danger/commands/local_helpers/pry_setup_spec.rb index d2a733937..432c889eb 100644 --- a/spec/lib/danger/commands/local_helpers/pry_setup_spec.rb +++ b/spec/lib/danger/commands/local_helpers/pry_setup_spec.rb @@ -19,7 +19,7 @@ end end - it "doesn't copy a nonexistant Dangerfile" do + it "doesn't copy a nonexistent Dangerfile" do described_class.new(testing_ui).setup_pry("", "pr") expect(File).not_to exist("_Dangerfile.tmp") From 9de58456eaedba4bfaa7920f01ac84f5b0fea2a0 Mon Sep 17 00:00:00 2001 From: ydah Date: Mon, 15 Apr 2024 11:45:04 +0900 Subject: [PATCH 4/7] fetchs ==> fetches --- lib/danger/request_sources/vsts.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/danger/request_sources/vsts.rb b/lib/danger/request_sources/vsts.rb index d6becebce..d8df9b76c 100644 --- a/lib/danger/request_sources/vsts.rb +++ b/lib/danger/request_sources/vsts.rb @@ -139,7 +139,7 @@ def update_old_comment(new_comment, danger_id: "danger") end def submit_inline_comments!(warnings: [], errors: [], messages: [], markdowns: [], previous_violations: [], danger_id: "danger") - # Avoid doing any fetchs if there's no inline comments + # Avoid doing any fetches if there's no inline comments return {} if (warnings + errors + messages + markdowns).select(&:inline?).empty? pr_threads = @api.fetch_last_comments From 4dcadd09c0399c50d78680e22a50b684c0f0ecec Mon Sep 17 00:00:00 2001 From: ydah Date: Mon, 15 Apr 2024 11:45:14 +0900 Subject: [PATCH 5/7] scrip ==> script --- lib/danger/ci_source/buildkite.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/danger/ci_source/buildkite.rb b/lib/danger/ci_source/buildkite.rb index b657bae2d..b81381e32 100644 --- a/lib/danger/ci_source/buildkite.rb +++ b/lib/danger/ci_source/buildkite.rb @@ -7,7 +7,7 @@ module Danger # ### CI Setup # # With BuildKite you run the server yourself, so you will want to run it as a part of your build process. - # It is common to have build steps, so we would recommend adding this to your scrip: + # It is common to have build steps, so we would recommend adding this to your script: # # ```shell # echo "--- Running Danger" From 22701ca3406aeedab83caf129389a24ca6023edd Mon Sep 17 00:00:00 2001 From: ydah Date: Mon, 15 Apr 2024 11:45:25 +0900 Subject: [PATCH 6/7] dependant ==> dependent --- lib/danger/helpers/comments_helper.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/danger/helpers/comments_helper.rb b/lib/danger/helpers/comments_helper.rb index 6b1755c3a..79eca6b67 100644 --- a/lib/danger/helpers/comments_helper.rb +++ b/lib/danger/helpers/comments_helper.rb @@ -35,7 +35,7 @@ def markdown_link_to_message(message, hide_link) # # request_source implementations are invited to override this method. # This is mostly here to enable sources to detect when inlines change only in their - # commit hash and not in content per-se. since the link is implementation dependant + # commit hash and not in content per-se. since the link is implementation dependent # so should be the comparison. # # @param [Violation or Markdown] m1 From 48b386cbc0953e225a12e76cdd098d515b6f5d5a Mon Sep 17 00:00:00 2001 From: ydah Date: Mon, 15 Apr 2024 11:46:02 +0900 Subject: [PATCH 7/7] doest ==> does --- spec/lib/danger/ci_sources/circle_spec.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spec/lib/danger/ci_sources/circle_spec.rb b/spec/lib/danger/ci_sources/circle_spec.rb index d3e20d24c..fa7d9edbb 100644 --- a/spec/lib/danger/ci_sources/circle_spec.rb +++ b/spec/lib/danger/ci_sources/circle_spec.rb @@ -89,7 +89,7 @@ expect(described_class.validates_as_pr?(invalid_env)).to be false end - it "doest not validate when required env variables are not set" do + it "does not validate when required env variables are not set" do expect(described_class.validates_as_pr?(invalid_env)).to be false end end