New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Danger pr now supports Bitbucket Server Pull Requests #1047

Merged
merged 8 commits into from Dec 10, 2018

Conversation

Projects
None yet
2 participants
@jmromanos
Copy link
Contributor

jmromanos commented Dec 10, 2018

This PR adds support for Bitbucket Server PRs in danger pr command.

This is a highly desired feature in our team at Adidas, as some members wanted to test some changes in our Dangerfiles locally without being required to open new pull requests to test in our CI environment

@orta

This comment has been minimized.

Copy link
Member

orta commented Dec 10, 2018

🎉 great, thanks, this looks 👍

@orta orta merged commit cb65e4e into danger:master Dec 10, 2018

4 checks passed

Peril All green. Jolly good show.
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@peril-staging

This comment has been minimized.

Copy link

peril-staging bot commented Dec 10, 2018

Thanks for the PR @jmromanos.

The Danger org conform to the Moya Community Continuity Guidelines, which means
that we want to offer any contributor the ability to control their destiny.

So, we've sent you an org invite - thanks jmromanos 🎉

Generated by 🚫 dangerJS

@peril-staging

This comment has been minimized.

Copy link

peril-staging bot commented Dec 10, 2018

Thanks for the PR @jmromanos.

This PR has been shipped in v5.10.0 - CHANGELOG.

@orta

This comment has been minimized.

Copy link
Member

orta commented Dec 10, 2018

and shipped, good stuff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment