/danger

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ruby2.6 to CI #1073

Merged
merged 4 commits into from Jan 24, 2019

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@colorbox @orta
@colorbox
Copy link
Member

colorbox commented Jan 24, 2019

This PR add ruby version, ruby 2.6.0 to CI.

colorbox and others added some commits Jan 24, 2019

@colorbox
Add ruby2.6 to CI
Loading status checks…
1cdf826
@colorbox
Update ruby version to not EOL version in cercleCI
Loading status checks…
ee86789
@colorbox
Update bundler version for CircleCI
Loading status checks…
7c76b7d
@orta
Try install the same bundler in travis
Verified
This commit was signed with a verified signature.
@orta orta Orta
GPG key ID: 5B78C3A449D5C17E Learn about signing commits
Loading status checks…
2de3e26
@orta

This comment has been minimized.

Sign in to view
Copy link
Member

orta commented Jan 24, 2019

Thanks!

@orta orta merged commit ae55c0f into danger:master Jan 24, 2019
4 checks passed

4 checks passed

Peril All green. Well done.
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@peril-staging

This comment has been minimized.

Sign in to view
Copy link

peril-staging bot commented Jan 24, 2019

Thanks for the PR @colorbox.

The Danger org conform to the Moya Community Continuity Guidelines, which means
that we want to offer any contributor the ability to control their destiny.

So, we've sent you an org invite - thanks colorbox 🎉

Generated by 🚫 dangerJS

@orta orta referenced this pull request Jan 24, 2019

Closed

Support more bundlers #1067

@peril-staging

This comment has been minimized.

Sign in to view
Copy link

peril-staging bot commented Jan 24, 2019

Thanks for the PR @colorbox.

This PR has been shipped in v5.12.0 - CHANGELOG.
@colorbox

This comment has been minimized.

Sign in to view
Copy link
Member Author

colorbox commented Jan 25, 2019

thank you for your additional commit 🙏

@colorbox colorbox deleted the colorbox:add-ruby2.6 branch Jan 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment