Gitlab #299

k0nserv · 2016-07-04T21:12:25Z

Opening this PR for tracking purposes and comments from everyone else. There's still some work that needs to be finished up

Implement and adopt tests
Make sure we get a new version of the gitlab gem issued
For GitLab CI to work we need to convince/implement some changes in GitLab

cc @orta, @connorshea, @hjanuschka, @jk

orta · 2016-07-04T21:20:27Z

lib/danger/danger_core/plugins/dangerfile_gitlab_plugin.rb

+    # The title of the Pull Request
+    # @return String
+    #
+    def pr_title


IMO, these should move to the gitlab vernacular - mr_title ( documentation around this will be handled fine 👍 )

Unless there's a need for a common interface

IMO, I don't think so, for Danger::RequestSources::GitLab there should be, ( you could add method aliases though, so that people can C&P examples that may reference the github names? I'd be on board with that. )

Yeah it's only used by the matching request source as of now so

DangerCI · 2016-07-04T21:25:10Z

	3 Errors
🚫	Please include a CHANGELOG entry. You can find it at CHANGELOG.md.
🚫	Failing due to documentation issues, see below.
🚫	The core plugins are not at 100% doc’d - see below:
✅	~~Please include a CHANGELOG entry. You can find it at CHANGELOG.md.~~
✅	~~Please include a CHANGELOG entry. You can find it at CHANGELOG.md.~~
✅	~~Please include a CHANGELOG entry. You can find it at CHANGELOG.md.~~

	1 Warning
⚠️	.gemspec modified
✅	~~External contributor has edited the Gemspec~~

	✅ Nice work.
✅	~~@k0nserv is not a contributor yet, would you like to join the Danger org?~~

Core Docs Errors

[!] Failed

Errors

Description Markdown - DangerfileGitLabPlugin (class):
- Above your class you need documentation that covers the scope, and the usage of your plugin.
- @see - https://github.com/dbgrandi/danger-prose/blob/v2.0.0/lib/danger_plugin.rb#L4#-L6
- /home/travis/build/danger/danger/lib/danger/danger_core/plugins/dangerfile_gitlab_plugin.rb:4
Examples - DangerfileGitLabPlugin (class):
- You should include some examples of common use-cases for your plugin.
- @see - https://github.com/dbgrandi/danger-prose/blob/v2.0.0/lib/danger_plugin.rb#L8#-L27
- /home/travis/build/danger/danger/lib/danger/danger_core/plugins/dangerfile_gitlab_plugin.rb:4

Warnings

Tags - DangerfileGitLabPlugin (class):
- This plugin does not include @tags tag1, tag2 and thus will be harder to find in search.
- @see - https://github.com/dbgrandi/danger-prose/blob/v2.0.0/lib/danger_plugin.rb#L30
- /home/travis/build/danger/danger/lib/danger/danger_core/plugins/dangerfile_gitlab_plugin.rb:4
References - DangerfileGitLabPlugin (class):
- Ideally, you have a reference implementation of your plugin that you can show to people, add @see org/repo to have the site auto link it.
- @see - https://github.com/dbgrandi/danger-prose/blob/v2.0.0/lib/danger_plugin.rb#L29
- /home/travis/build/danger/danger/lib/danger/danger_core/plugins/dangerfile_gitlab_plugin.rb:4
Return Type - pr_title (method):
- If the function has no useful return value, use @return [void] - this will be ignored by documentation generators.
- @see - https://github.com/dbgrandi/danger-prose/blob/v2.0.0/lib/danger_plugin.rb#L46
- /home/travis/build/danger/danger/lib/danger/danger_core/plugins/dangerfile_gitlab_plugin.rb:25
Return Type - pr_body (method):
- If the function has no useful return value, use @return [void] - this will be ignored by documentation generators.
- @see - https://github.com/dbgrandi/danger-prose/blob/v2.0.0/lib/danger_plugin.rb#L46
- /home/travis/build/danger/danger/lib/danger/danger_core/plugins/dangerfile_gitlab_plugin.rb:33
Return Type - pr_author (method):
- If the function has no useful return value, use @return [void] - this will be ignored by documentation generators.
- @see - https://github.com/dbgrandi/danger-prose/blob/v2.0.0/lib/danger_plugin.rb#L46
- /home/travis/build/danger/danger/lib/danger/danger_core/plugins/dangerfile_gitlab_plugin.rb:41
Return Type - branch_for_merge (method):
- If the function has no useful return value, use @return [void] - this will be ignored by documentation generators.
- @see - https://github.com/dbgrandi/danger-prose/blob/v2.0.0/lib/danger_plugin.rb#L46
- /home/travis/build/danger/danger/lib/danger/danger_core/plugins/dangerfile_gitlab_plugin.rb:57
Return Type - base_commit (method):
- If the function has no useful return value, use @return [void] - this will be ignored by documentation generators.
- @see - https://github.com/dbgrandi/danger-prose/blob/v2.0.0/lib/danger_plugin.rb#L46
- /home/travis/build/danger/danger/lib/danger/danger_core/plugins/dangerfile_gitlab_plugin.rb:65
Return Type - head_commit (method):
- If the function has no useful return value, use @return [void] - this will be ignored by documentation generators.
- @see - https://github.com/dbgrandi/danger-prose/blob/v2.0.0/lib/danger_plugin.rb#L46
- /home/travis/build/danger/danger/lib/danger/danger_core/plugins/dangerfile_gitlab_plugin.rb:73

Files:           5
Modules:         1 (    0 undocumented)
Classes:         5 (    1 undocumented)
Constants:       0 (    0 undocumented)
Attributes:      0 (    0 undocumented)
Methods:        48 (    2 undocumented)
 94.44% documented

Undocumented Objects:

(in file: lib/danger/danger_core/plugins/dangerfile_gitlab_plugin.rb)
Danger::DangerfileGitLabPlugin
Danger::DangerfileGitLabPlugin.new
Danger::DangerfileGitLabPlugin.instance_name

Generated by 🚫 danger

k0nserv · 2016-07-04T21:29:00Z

On the topic of the gitlab gem I've reached out to Narkos over email. He is the registered owner of the gem on https://rubygems.org. Issuing a 3.7.0 of gitlab is currently the largest blocker for this to be merged

orta · 2016-07-07T11:04:50Z

@k0nserv any reply from Narkos?

k0nserv · 2016-07-07T11:06:30Z

No word from Narkos yet. You wanna try the Rubygems route?

k0nserv · 2016-07-07T11:07:20Z

Might be possible to convince them to give @asedge push access

hjanuschka · 2016-07-07T11:09:00Z

i would be scared if it would work!

how about forking it to gitlab-official or gitlab-gitlab?

orta · 2016-07-07T13:56:05Z

I think it's better we see if we can get either the attention of asedge, or someone who works at GitLab, it's a pretty clear-cut choice to say that they should have access in the absence of Narkos.

connorshea · 2016-07-07T14:57:28Z

I'm undecided as to whether we should try to get control of the gem or create a new one, I've asked fellow GitLabbers for their input.

It'd also be good to have your thoughts, @asedge, seeing as you're the primary maintainer currently.

k0nserv · 2016-07-07T18:16:24Z

@orta Do you wanna exclude GitLab CI on account of it not being supported as of now?

orta · 2016-07-07T18:17:19Z

You mean merge this, but not let the code-paths be accessible? That can work for me

k0nserv · 2016-07-07T18:18:46Z

Either that or not merge it at all. Until they support some way of exposing the MR id in GitLab CI Danger won't work at all, even after that they need to support triggering builds on comments/edits for full support

k0nserv · 2016-07-07T18:19:41Z

All though if we include it as it stands right now people are free to build small servers that interact with GitLab's build hooks to expose the correct env variables

justMaku · 2016-07-07T18:23:02Z

I'd merge it and allow people to build their own workflows, even if GitLab CI doesn't work now, people can still use Jenkins or any other form of CI to trigger the build.

k0nserv · 2016-07-07T18:24:35Z

The question is not about other CI tools though, it's specifically about Danger::CISource::GitlabCI.

orta · 2016-07-07T18:26:10Z

Aye, I'm on the let's merge it, but comment out the Danger::CISource::GitlabCI - it'll end up in the autogenerated docs on the website

justMaku · 2016-07-07T18:26:19Z

I also believe that assuming that Danger only works on PRs is wrong as in fact danger could work on any given changeset. We need to start thinking about removing that tight coupling somehow and maybe even move out PR updaters to a plugin.

orta · 2016-07-07T18:29:33Z

I also believe that assuming that Danger only works on PRs is wrong as in fact danger could work on any given changeset.

Could, yes, I guess I can see some usage as a pre-linter, but it might not be worth the overhead for support.

deanpcmad · 2016-08-14T22:09:29Z

👍 looking forward to adding this to all my tests now 😃

orta · 2016-08-16T20:41:22Z

There's also the question of organization danger files which isn't implemented yet

Don't do this ATM, I've already removed it in one PR - #418 - I'm not sure what its replacement should look like yet

connorshea · 2016-08-16T23:52:00Z

Hey all, we've gotten the current maintainer of the GitLab gem able to ship new releases! 3.7.0 is now out! https://rubygems.org/gems/gitlab

orta · 2016-08-17T00:31:40Z

🎉

k0nserv · 2016-08-20T16:14:36Z

I believe this should be ready for review now. I haven't written any code to update the status of the merge request yet, but I'd prefer to merge first and then add this

k0nserv · 2016-08-20T16:15:51Z

The other thing that remains is updating CI sources that support GitLab. I don't believe this to be a blocker for the merge either

…bles

Instead of relying on width="100%" which is specific to the github markdown to find danger tables use `data-danger-table="true"`

orta · 2016-08-20T18:34:44Z

lib/danger/helpers/comments_helper.rb

+        # The new method uses a more robust data-danger-table
+        # tag instead.
+        match = GITHUB_OLD_REGEX.match(table)
+        return match if match


orta · 2016-08-20T19:00:40Z

OK, so yeah, this looks good, I have only minor nitpicks about the tests - but that's not a blocker for me at all. I'm going to merge this into another branch on danger ( I want to be able to deploy master whenever ) so I can get this rebased, documented and green. A new PR will be coming in soon, once I get back to my main computer.

This has been a bunch of work from a quite a few developers, thanks to all of you. 💯

hjanuschka · 2016-08-21T21:04:07Z

nice thx guys!!!

k0nserv mentioned this pull request Jul 4, 2016

[WIP] - add gitlab support + SPLIT out APISources #59

Closed

k0nserv force-pushed the gitlab branch from 956deeb to fe435c9 Compare July 4, 2016 21:14

orta reviewed Jul 4, 2016
View reviewed changes

k0nserv force-pushed the gitlab branch from fe435c9 to 2eca8c0 Compare July 4, 2016 21:24

k0nserv force-pushed the gitlab branch 3 times, most recently from a51e545 to 9c3ddc0 Compare July 5, 2016 21:52

orta mentioned this pull request Jul 7, 2016

Bitbucket integration #315

Closed

k0nserv force-pushed the gitlab branch 2 times, most recently from c4129a6 to 312e59b Compare July 7, 2016 18:15

k0nserv force-pushed the gitlab branch 2 times, most recently from 1238b3d to 634a525 Compare July 7, 2016 22:05

k0nserv force-pushed the gitlab branch 2 times, most recently from 336a98e to 9563012 Compare August 20, 2016 16:13

Hugo Tunius and others added 10 commits August 20, 2016 17:21

[GitLab] Initial support

5f505b9

added bin/console to easily access irb

e5a6de4

some work on fixing tests

a396f1f

set the right env

58706c6

fixed environment manager tests

325123d

updated gitlab ci source. PR and MR currently aren’t set as env varia…

07195a2

…bles

validates? -> validates_as_api_source? for request sources

2764f98

[Parsing] Improve identification of danger tables

846f47c

Instead of relying on width="100%" which is specific to the github markdown to find danger tables use `data-danger-table="true"`

[GitLab] Finalize tests and support

52ce98e

[Gems] Use gitlab via gemspec

31add08

k0nserv force-pushed the gitlab branch from 9563012 to 31add08 Compare August 20, 2016 16:21

orta reviewed Aug 20, 2016
View reviewed changes

orta changed the base branch from master to gitlab_docs August 20, 2016 19:00

orta merged commit 5f2572c into danger:gitlab_docs Aug 20, 2016

k0nserv deleted the gitlab branch August 21, 2016 21:06

k0nserv changed the title ~~[WIP] Gitlab~~ Gitlab Aug 22, 2016

orta mentioned this pull request Oct 17, 2017

Using DangerJS with GitLab/BitBucket danger/danger-js#396

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Gitlab #299

Gitlab #299

k0nserv commented Jul 4, 2016 •

edited

Loading

orta Jul 4, 2016

k0nserv Jul 4, 2016

k0nserv Jul 4, 2016

orta Jul 4, 2016

k0nserv Jul 4, 2016

DangerCI commented Jul 4, 2016 •

edited

Loading

k0nserv commented Jul 4, 2016

orta commented Jul 7, 2016

k0nserv commented Jul 7, 2016

k0nserv commented Jul 7, 2016

hjanuschka commented Jul 7, 2016

orta commented Jul 7, 2016

connorshea commented Jul 7, 2016

k0nserv commented Jul 7, 2016 •

edited

Loading

orta commented Jul 7, 2016

k0nserv commented Jul 7, 2016

k0nserv commented Jul 7, 2016

justMaku commented Jul 7, 2016

k0nserv commented Jul 7, 2016

orta commented Jul 7, 2016

justMaku commented Jul 7, 2016

orta commented Jul 7, 2016

deanpcmad commented Aug 14, 2016

orta commented Aug 16, 2016

connorshea commented Aug 16, 2016

orta commented Aug 17, 2016

k0nserv commented Aug 20, 2016

k0nserv commented Aug 20, 2016

orta Aug 20, 2016

orta commented Aug 20, 2016

hjanuschka commented Aug 21, 2016

Gitlab #299

Gitlab #299

Conversation

k0nserv commented Jul 4, 2016 • edited Loading

orta Jul 4, 2016

Choose a reason for hiding this comment

k0nserv Jul 4, 2016

Choose a reason for hiding this comment

k0nserv Jul 4, 2016

Choose a reason for hiding this comment

orta Jul 4, 2016

Choose a reason for hiding this comment

k0nserv Jul 4, 2016

Choose a reason for hiding this comment

DangerCI commented Jul 4, 2016 • edited Loading

Core Docs Errors

k0nserv commented Jul 4, 2016

orta commented Jul 7, 2016

k0nserv commented Jul 7, 2016

k0nserv commented Jul 7, 2016

hjanuschka commented Jul 7, 2016

orta commented Jul 7, 2016

connorshea commented Jul 7, 2016

k0nserv commented Jul 7, 2016 • edited Loading

orta commented Jul 7, 2016

k0nserv commented Jul 7, 2016

k0nserv commented Jul 7, 2016

justMaku commented Jul 7, 2016

k0nserv commented Jul 7, 2016

orta commented Jul 7, 2016

justMaku commented Jul 7, 2016

orta commented Jul 7, 2016

deanpcmad commented Aug 14, 2016

orta commented Aug 16, 2016

connorshea commented Aug 16, 2016

orta commented Aug 17, 2016

k0nserv commented Aug 20, 2016

k0nserv commented Aug 20, 2016

orta Aug 20, 2016

Choose a reason for hiding this comment

orta commented Aug 20, 2016

hjanuschka commented Aug 21, 2016

k0nserv commented Jul 4, 2016 •

edited

Loading

DangerCI commented Jul 4, 2016 •

edited

Loading

k0nserv commented Jul 7, 2016 •

edited

Loading