New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for 2.0 release #362

Merged
merged 4 commits into from Jul 25, 2016

Conversation

Projects
None yet
4 participants
@orta
Member

orta commented Jul 25, 2016

This is the one.

Mid-April 2015, I wrote down in an issue artsy/mobile#31 (comment) that we really should start automating some of the cultural rules we were establishing in Artsy.

6 Months later in September, I wrote the first commit 54bff64. Within a hour or so I had ripped enough code from CocoaPods to make a working prototype 0a429b4. By the end of the day, it did all of the basics f574143. By start of 2016 it was in production at Arsty artsy/eigen#1013.

@KrauseFx and I played "who owns Danger" for a while, and eventually managed to get an org for the project. My origin remote for Danger still points to https://github.com/krausefx/danger/.

Since then we've expanded to support:

  • Running on Circle, Travis, Jenkins, Buildkite, Semaphore, TeamCity, Xcode Bots, Drone, Surf.
  • An amazing plugin system, bootstrapped by @KrauseFx and @dbgrandi
  • Windows ;)
  • All sorts of work flows
  • 25 contributors, over 1000 commits across the projects

and soon GitLab and Bitbucket.

My last month of work on Danger - started with some README driven design, danger/danger.systems@a7f0cb2 covering all of the concept for http://danger.systems. This has been one of the biggest automation project I've worked on, it's ready in case Danger gets big. Danger Systems is a really cool project that should really help ease the amount of support requests we get. More docs = 馃懐 .

I even have a Danger spotify playlist.


Thanks everyone who has helped out, this would be such a different project without you all.


Why 2.0? Well, it's a final homage to Danger. She's the real 1.0 - can't try to replicate her.

I want to wait till tomorrow to merge this, and announce Danger is ready. 馃憤

@DangerCI

This comment has been minimized.

Show comment
Hide comment
@DangerCI

DangerCI Jul 25, 2016

1 Warning
鈿狅笍 .gemspec modified

Generated by 馃毇 danger

DangerCI commented Jul 25, 2016

1 Warning
鈿狅笍 .gemspec modified

Generated by 馃毇 danger

@orta

This comment has been minimized.

Show comment
Hide comment
@orta

orta Jul 25, 2016

Member

what is up with these fails?

Member

orta commented Jul 25, 2016

what is up with these fails?

@KrauseFx

This comment has been minimized.

Show comment
Hide comment
@KrauseFx

KrauseFx Jul 25, 2016

Member
lib/danger/commands/init_helpers/interviewer.rb:75:24: C: Omit parentheses for ternary conditions.
          the_answer = (i == 0) ? answer.underline : answer
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/danger/commands/init_helpers/interviewer.rb:75:25: C: Use i.zero? instead of i == 0.
          the_answer = (i == 0) ? answer.underline : answer
                        ^^^^^^
lib/danger/danger_core/dangerfile.rb:52:5: C: When using method_missing, define respond_to_missing?.
    def method_missing(method_sym, *arguments, &_block) ...
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/danger/danger_core/dangerfile.rb:198:17: C: Use (status[:errors] + status[:warnings] + status[:messages] + status[:markdowns]).count.zero? instead of (status[:errors] + status[:warnings] + status[:messages] + status[:markdowns]).count == 0.
      return if (status[:errors] + status[:warnings] + status[:messages] + status[:markdowns]).count == 0
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/danger/plugin_support/plugin.rb:20:5: C: When using method_missing, define respond_to_missing? and fall back on super.
    def method_missing(method_sym, *arguments, &block) ...
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/danger/request_source/github.rb:114:19: C: Use errors.count.zero? instead of errors.count == 0.
        status = (errors.count == 0 ? 'success' : 'failure')
                  ^^^^^^^^^^^^^^^^^
70 files inspected, 6 offenses detected

Interesting that only Travis failed the build.

Member

KrauseFx commented Jul 25, 2016

lib/danger/commands/init_helpers/interviewer.rb:75:24: C: Omit parentheses for ternary conditions.
          the_answer = (i == 0) ? answer.underline : answer
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/danger/commands/init_helpers/interviewer.rb:75:25: C: Use i.zero? instead of i == 0.
          the_answer = (i == 0) ? answer.underline : answer
                        ^^^^^^
lib/danger/danger_core/dangerfile.rb:52:5: C: When using method_missing, define respond_to_missing?.
    def method_missing(method_sym, *arguments, &_block) ...
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/danger/danger_core/dangerfile.rb:198:17: C: Use (status[:errors] + status[:warnings] + status[:messages] + status[:markdowns]).count.zero? instead of (status[:errors] + status[:warnings] + status[:messages] + status[:markdowns]).count == 0.
      return if (status[:errors] + status[:warnings] + status[:messages] + status[:markdowns]).count == 0
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/danger/plugin_support/plugin.rb:20:5: C: When using method_missing, define respond_to_missing? and fall back on super.
    def method_missing(method_sym, *arguments, &block) ...
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/danger/request_source/github.rb:114:19: C: Use errors.count.zero? instead of errors.count == 0.
        status = (errors.count == 0 ? 'success' : 'failure')
                  ^^^^^^^^^^^^^^^^^
70 files inspected, 6 offenses detected

Interesting that only Travis failed the build.

@orta

This comment has been minimized.

Show comment
Hide comment
@orta

orta Jul 25, 2016

Member

I think it's not using the bundle'd rubocop, those linters got added in the last few days. I've bumped our bundler version, and fixed them

Member

orta commented Jul 25, 2016

I think it's not using the bundle'd rubocop, those linters got added in the last few days. I've bumped our bundler version, and fixed them

@@ -17,6 +17,8 @@ def self.instance_name
# Since we have a reference to the Dangerfile containing all the information
# We need to redirect the self calls to the Dangerfile
# rubocop:disable Style/MethodMissing
def method_missing(method_sym, *arguments, &block)

This comment has been minimized.

@segiddins

segiddins Jul 25, 2016

Member

you need to implement respond_to_missing? here

@segiddins

segiddins Jul 25, 2016

Member

you need to implement respond_to_missing? here

This comment has been minimized.

@orta

orta Jul 25, 2016

Member

in the next release, I'm not adding something I don't understand entirely, an hour or two before release.

@orta

orta Jul 25, 2016

Member

in the next release, I'm not adding something I don't understand entirely, an hour or two before release.

@orta

This comment has been minimized.

Show comment
Hide comment
@orta

orta Jul 25, 2016

Member

Alright, I'm calling this green, it works locally and it looks like travis/pr seems to have locked on two of our ruby versions.

screen shot 2016-07-25 at 11 21 00 am

Member

orta commented Jul 25, 2016

Alright, I'm calling this green, it works locally and it looks like travis/pr seems to have locked on two of our ruby versions.

screen shot 2016-07-25 at 11 21 00 am

@orta orta merged commit 492e2a3 into master Jul 25, 2016

4 of 5 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@orta orta deleted the version branch Jul 25, 2016

@orta orta restored the version branch Jul 25, 2016

@segiddins segiddins deleted the version branch Jul 25, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment