Support JavaScript Dangerfiles #422

Merged
merged 17 commits into from Aug 13, 2016

Conversation

Projects
None yet
4 participants
@orta
Member

orta commented Aug 12, 2016

This adds rudimentary support for JavaScript Dangerfiles.

  • Decide on the Rubygems situation
  • Executor should decide which Dangerfile type to run

Then I can start looking at using it in production on Emission to test out some of the more complex interactions.

hanneskaeufler and others added some commits Aug 7, 2016

fix rubocop issues excluded through .rubocop_todo
All of theme were double/single quote issues. Remove rubocop_todo.yml
because all the issues are fixed.
Merge pull request #417 from hanneskaeufler/hk-remove-rubocop-todos
fix rubocop issues excluded through .rubocop_todo #trivial
Merge pull request #420 from danger/marcelofabri-patch-1
Update link for pr_json fixture #trivial
@orta

This comment has been minimized.

Show comment
Hide comment
@orta

orta Aug 12, 2016

Member

Think I will include a separate gem, danger-js which only has two dependencies danger and therubyracer. I'll recommend that JS users have that as their dependency.

This means less gems for anyone currently using it, including v8 which is a native module.

Member

orta commented Aug 12, 2016

Think I will include a separate gem, danger-js which only has two dependencies danger and therubyracer. I'll recommend that JS users have that as their dependency.

This means less gems for anyone currently using it, including v8 which is a native module.

@orta

This comment has been minimized.

Show comment
Hide comment

@orta orta added the JavaScript label Aug 12, 2016

@DangerCI

This comment has been minimized.

Show comment
Hide comment
@DangerCI

DangerCI Aug 13, 2016

1 Warning
⚠️ .gemspec modified

Generated by 🚫 danger

DangerCI commented Aug 13, 2016

1 Warning
⚠️ .gemspec modified

Generated by 🚫 danger

@DangerCI

This comment has been minimized.

Show comment
Hide comment
@DangerCI

DangerCI Aug 13, 2016

1 Message
📖 Hello

Generated by 🚫 danger

DangerCI commented Aug 13, 2016

1 Message
📖 Hello

Generated by 🚫 danger

@orta orta merged commit b5ceb81 into js Aug 13, 2016

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@orta orta deleted the more_js branch Aug 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment