From 83dc9aa9880df2d46ff431c60f7c955f60c199e4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C5=81ukasz=20Mro=CC=81z?= Date: Fri, 17 Mar 2017 23:19:49 +0100 Subject: [PATCH 1/5] Add buddybuild ci_source --- lib/danger/ci_source/buddybuild.rb | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) create mode 100644 lib/danger/ci_source/buddybuild.rb diff --git a/lib/danger/ci_source/buddybuild.rb b/lib/danger/ci_source/buddybuild.rb new file mode 100644 index 000000000..a7f329175 --- /dev/null +++ b/lib/danger/ci_source/buddybuild.rb @@ -0,0 +1,20 @@ +module Danger + # ### CI Setup + # ### Token Setup + class Buddybuild < CI + def self.validates_as_ci?(env) + false + end + + def self.validates_as_pr?(env) + false + end + + def initialize(env) + end + + def supported_request_sources + @supported_request_sources ||= [] + end + end +end From d5ec5f94ca6311743bf2281496a7dcac6e55bdd9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C5=81ukasz=20Mro=CC=81z?= Date: Sun, 19 Mar 2017 02:38:07 +0100 Subject: [PATCH 2/5] Add CI description --- lib/danger/ci_source/buddybuild.rb | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/lib/danger/ci_source/buddybuild.rb b/lib/danger/ci_source/buddybuild.rb index a7f329175..f615f10ce 100644 --- a/lib/danger/ci_source/buddybuild.rb +++ b/lib/danger/ci_source/buddybuild.rb @@ -1,6 +1,22 @@ module Danger # ### CI Setup + # + # Buddybuild has an integration for Danger already built-in. + # What you need to do is to upload your `Gemfile` and `Dangerfile` to + # the server and you should be all set-up. However, if you want to use + # different bot for Danger, you can do it with token setup described below. + # # ### Token Setup + # + # Login to buddybuild and select your app. Go to your *App Settings* and + # in the *Build Settings* menu on the left, choose *Environment Variables*. + # + # #### GitHub + # Add the `DANGER_GITHUB_API_TOKEN` to your build user's ENV. + # + # #### GitLab + # Add the `DANGER_GITLAB_API_TOKEN` to your build user's ENV. + class Buddybuild < CI def self.validates_as_ci?(env) false From eec3b5abfafd6dd704f84642bff3ee4b9287677e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C5=81ukasz=20Mro=CC=81z?= Date: Sun, 19 Mar 2017 02:41:05 +0100 Subject: [PATCH 3/5] Add changelog entry --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index e33cc7569..30f458dbe 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,6 +3,7 @@ * Add your own contribution below * Fix find inline comment position at the last line of diff - leonhartX * Add inline comments to changed lines only when `dismiss_out_of_range_message` is enabled - leonhartX +* Add documentation for [buddybuild](https://www.buddybuild.com) - sunshinejr ## 4.3.0 From 3bb6f3b1529e401a2cf92ba0b03974851a1c2f7e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C5=81ukasz=20Mro=CC=81z?= Date: Sun, 19 Mar 2017 02:52:39 +0100 Subject: [PATCH 4/5] Fix ci_source_spec --- spec/lib/danger/ci_sources/ci_source_spec.rb | 1 + 1 file changed, 1 insertion(+) diff --git a/spec/lib/danger/ci_sources/ci_source_spec.rb b/spec/lib/danger/ci_sources/ci_source_spec.rb index 629c4711d..802e30c21 100644 --- a/spec/lib/danger/ci_sources/ci_source_spec.rb +++ b/spec/lib/danger/ci_sources/ci_source_spec.rb @@ -7,6 +7,7 @@ [ "Danger::LocalGitRepo", "Danger::Bitrise", + "Danger::Buddybuild", "Danger::Buildkite", "Danger::CircleCI", "Danger::Drone", From 14e58b438ddb5b1058418827ca2a0a7457bccc2e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C5=81ukasz=20Mro=CC=81z?= Date: Sun, 19 Mar 2017 03:04:32 +0100 Subject: [PATCH 5/5] Fix danger offenses --- lib/danger/ci_source/buddybuild.rb | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/lib/danger/ci_source/buddybuild.rb b/lib/danger/ci_source/buddybuild.rb index f615f10ce..c4088c7a9 100644 --- a/lib/danger/ci_source/buddybuild.rb +++ b/lib/danger/ci_source/buddybuild.rb @@ -1,15 +1,15 @@ module Danger # ### CI Setup # - # Buddybuild has an integration for Danger already built-in. - # What you need to do is to upload your `Gemfile` and `Dangerfile` to - # the server and you should be all set-up. However, if you want to use + # Buddybuild has an integration for Danger already built-in. + # What you need to do is to upload your `Gemfile` and `Dangerfile` to + # the server and you should be all set-up. However, if you want to use # different bot for Danger, you can do it with token setup described below. # # ### Token Setup # - # Login to buddybuild and select your app. Go to your *App Settings* and - # in the *Build Settings* menu on the left, choose *Environment Variables*. + # Login to buddybuild and select your app. Go to your *App Settings* and + # in the *Build Settings* menu on the left, choose *Environment Variables*. # # #### GitHub # Add the `DANGER_GITHUB_API_TOKEN` to your build user's ENV. @@ -18,16 +18,15 @@ module Danger # Add the `DANGER_GITLAB_API_TOKEN` to your build user's ENV. class Buddybuild < CI - def self.validates_as_ci?(env) + def self.validates_as_ci?(_) false end - def self.validates_as_pr?(env) + def self.validates_as_pr?(_) false end - def initialize(env) - end + def initialize(_) end def supported_request_sources @supported_request_sources ||= []