New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scheduler #138

Closed
orta opened this Issue Aug 30, 2017 · 5 comments

Comments

Projects
None yet
2 participants
@orta
Member

orta commented Aug 30, 2017

I'd like a scheduler - this would execute a Dangerfile with an instance of the github API at a scheduled rate and do specific jobs, here's a few tasks that I'd do with this:

@flovilmart

This comment has been minimized.

Contributor

flovilmart commented Aug 30, 2017

scheduling is hard :P how do you envision it? a setTimeout in the process, a cron on a standalone danger like danger --sanity --source path/to/Dangerfile.js ?

@orta

This comment has been minimized.

Member

orta commented Aug 30, 2017

I'm also a bit unsure, maybe a heroku scheduler would keep things neatly separated in terms of abstraction. I've used setTimeout a bunch and also not really had a problem with it, so don't really have opinions 🍡 :D

@flovilmart

This comment has been minimized.

Contributor

flovilmart commented Aug 30, 2017

from what I see with parse-server, a standalone batch executor (that is side-effect-less) is better.

@orta

This comment has been minimized.

Member

orta commented Aug 31, 2017

Thanks!

@orta

This comment has been minimized.

Member

orta commented Jan 28, 2018

OK, we now have all sorts of scheduling options (in x amount of minutes, every x minutes)

https://github.com/danger/peril/blob/master/docs/settings_repo_info.md#scheduler

@orta orta closed this Jan 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment