Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upFixes multiple task repition bug #407
Conversation
ashfurrow
assigned
orta
Jan 7, 2019
This comment has been minimized.
This comment has been minimized.
|
Yep, this totally makes sense! |
orta
merged commit 0db941d
into
danger:master
Jan 7, 2019
ashfurrow
deleted the
ashfurrow:tasks-array-bug-fix
branch
Jan 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
ashfurrow commentedJan 7, 2019
I'm not 100% sure about this bug fix, but we've been seeing this problem at Artsy where RFC tasks get run multiple times where configured in an array:
https://github.com/artsy/peril-settings/blob/36ccb57d6aea1ffd88fbb93cce8f9429fcc75724/peril.settings.json#L43
It looks like it just runs the first task over and again for each element in that array. I think this PR fixes that, but I didn't see a test to be sure.