New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes multiple task repition bug #407

Merged
merged 1 commit into from Jan 7, 2019

Conversation

Projects
None yet
2 participants
@ashfurrow
Copy link
Member

ashfurrow commented Jan 7, 2019

I'm not 100% sure about this bug fix, but we've been seeing this problem at Artsy where RFC tasks get run multiple times where configured in an array:

https://github.com/artsy/peril-settings/blob/36ccb57d6aea1ffd88fbb93cce8f9429fcc75724/peril.settings.json#L43

It looks like it just runs the first task over and again for each element in that array. I think this PR fixes that, but I didn't see a test to be sure.

@orta

This comment has been minimized.

Copy link
Member

orta commented Jan 7, 2019

Yep, this totally makes sense!

@orta orta merged commit 0db941d into danger:master Jan 7, 2019

2 checks passed

Peril All green. Good on 'ya.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ashfurrow ashfurrow deleted the ashfurrow:tasks-array-bug-fix branch Jan 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment