New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate the Danger library from the Runner #109

Merged
merged 5 commits into from Nov 16, 2018

Conversation

Projects
None yet
3 participants
@f-meloni
Copy link
Member

f-meloni commented Nov 16, 2018

Originally some stuff that was used only from the runner was on the Danger library.
I thought it was a good idea to actually make them independent, and also it was cleaner to have a specific library for the stuff we use on the Runner

@DangerCI

This comment has been minimized.

Copy link

DangerCI commented Nov 16, 2018

Warnings
⚠️ Big PR, try to keep changes smaller if you can

Generated by 🚫 dangerJS

@orta

This comment has been minimized.

Copy link
Member

orta commented Nov 16, 2018

Cool, seems fine with me 👍

@orta orta merged commit 8880a11 into danger:master Nov 16, 2018

2 checks passed

Peril All green. Jolly good show.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment