New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help Option #122

Merged
merged 19 commits into from Nov 23, 2018

Conversation

Projects
None yet
3 participants
@f-meloni
Copy link
Member

f-meloni commented Nov 23, 2018

this is the danger-swift help result from terminal.

screenshot 2018-11-23 at 12 20 40

Also hopefully it auto generates the LinuxMain now and we won't have to maintain it anymore :D

@DangerCI

This comment has been minimized.

Copy link

DangerCI commented Nov 23, 2018

Warnings
⚠️ Big PR, try to keep changes smaller if you can

Generated by 🚫 dangerJS

@f-meloni

This comment has been minimized.

Copy link
Member

f-meloni commented Nov 23, 2018

swift test --generate-linuxmain can be executed just on osx because requires objc runtime, but is still better than maintain the list of tests manually.
I've added also another instance of travis that checks that the tests are always up to date in the files that are used by Linux

@f-meloni f-meloni changed the title Help Help Command Nov 23, 2018

@f-meloni f-meloni requested a review from orta Nov 23, 2018

@orta

This comment has been minimized.

Copy link
Member

orta commented Nov 23, 2018

Nice - this should be danger-swift --help and not a separate command, this allows all commands to have a help command - other than that - looks 👍

import Logger

public final class HelpMessagePresenter {
public static func showHelpMessage(command: DangerCommand?, logger: Logger) {

This comment has been minimized.

@f-meloni

f-meloni Nov 23, 2018

Member

I passed the command here then we will be able to show the command specific help if any

This comment has been minimized.

@orta

orta Nov 23, 2018

Member

👍

@f-meloni f-meloni changed the title Help Command Help Option Nov 23, 2018

@f-meloni

This comment has been minimized.

Copy link
Member

f-meloni commented Nov 23, 2018

merge on green

@peril-staging peril-staging bot merged commit 6d93dbf into master Nov 23, 2018

2 checks passed

Peril All green. Woo!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@f-meloni f-meloni deleted the help branch Nov 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment