New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merges in Danger SwiftLint #146

Merged
merged 1 commit into from Dec 19, 2018

Conversation

Projects
None yet
3 participants
@orta
Copy link
Member

orta commented Dec 17, 2018

Closes ashfurrow/danger-swiftlint#17 and merges SwiftLint into Danger. This will need another docs refresh, but then I think this'll get a big mention on the index for the website.

I mainly brought it over wholesale, and then edited the tests to re-use some of the new testing infra

It'll need to support running via SwiftPM so we can use it on Danger Swift itself, but getting there.

This is a big enough move that I'd like to get sign off from both @ashfurrow @sunshinejr because moving this in re-assigns the copyright to the Danger Swift license instead of the one from danger swiftlint.

@ashfurrow
Copy link
Member

ashfurrow left a comment

Yup, fine by me 👍

@sunshinejr
Copy link
Member

sunshinejr left a comment

I think that’s a great addition 👍🏻

@orta

This comment has been minimized.

Copy link
Member Author

orta commented Dec 19, 2018

OK, cool, let's get this in.

@orta orta merged commit 6449309 into master Dec 19, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@HeEAaD HeEAaD deleted the merge_swiftlint branch Jan 29, 2019

@danger danger deleted a comment from peril-staging bot Feb 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment