Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix danger edit for SPM #204

Merged
merged 7 commits into from Feb 24, 2019

Conversation

Projects
None yet
2 participants
@f-meloni
Copy link
Member

f-meloni commented Feb 24, 2019

swift run danger-swift edit doesn't compile if SPM generates the libDanger.dylib without the Danger.swiftmodule instead of generate only the libDangerDeps.dylib with the Danger.swiftmodule as it does on this repo.
e.g.
schermata 2019-02-24 alle 19 21 08

This PR fixes that

@DangerCI

This comment has been minimized.

Copy link

DangerCI commented Feb 24, 2019

Warnings
⚠️

Sources/Danger-Swift/Fake.swift#L1 - Files should have a single trailing newline. (trailing_newline)

Generated by 🚫 Danger Swift against 5868186

@f-meloni f-meloni merged commit 7bbbcb4 into master Feb 24, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@f-meloni f-meloni deleted the fix_danger_edit_for_spm branch Feb 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.