Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove free floating "mutating" keyword from DangerDSL #241

Merged
merged 1 commit into from May 23, 2019

Conversation

@sunshinejr
Copy link
Member

commented May 23, 2019

Fixes #240. Hopefully! 馃槃

@sunshinejr sunshinejr requested a review from f-meloni May 23, 2019

@davdroman

This comment has been minimized.

Copy link

commented May 23, 2019

Great response time @sunshinejr! 馃槃

@f-meloni

This comment has been minimized.

Copy link
Member

commented May 23, 2019

Amazing, thank you :)

@f-meloni

This comment has been minimized.

Copy link
Member

commented May 23, 2019

merge on green

@sunshinejr

This comment has been minimized.

Copy link
Member Author

commented May 23, 2019

haha, just tried to be as fast as you with your issue timing @davdroman! love it that you can do these kinds of PRs straight from the GitHub web app and so it can be done in seconds.

@f-meloni

This comment has been minimized.

Copy link
Member

commented May 23, 2019

Apparently I had it in my local git (not sure why), and with the of Rocket's add . it entered by mistake in the release... Sorry :(

@@ -16,7 +16,6 @@ public struct DangerDSL: Decodable {
public private(set) var github: GitHub!

public let bitbucketServer: BitBucketServer!
mutating

This comment has been minimized.

Copy link
@DangerCI

DangerCI May 23, 2019

  • 鈿狅笍 Lines should not have trailing whitespace. (trailing_whitespace)
@DangerCI

This comment has been minimized.

Copy link

commented May 23, 2019

Warnings
鈿狅笍

Any changes to library code should be reflected in the Changelog.

Please consider adding a note there and adhere to the Changelog Guidelines.

Generated by 馃毇 Danger Swift against d67d3bb

@f-meloni

This comment has been minimized.

Copy link
Member

commented May 23, 2019

I should add a flag to Rocket to ensure the git status is clean before start the release

@f-meloni

This comment has been minimized.

Copy link
Member

commented May 23, 2019

Ok looks good, not waiting for brew in CI because it wouldn't pass anyway

@f-meloni f-meloni merged commit 5a21166 into master May 23, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Danger All good
Details
@peril-staging

This comment has been minimized.

Copy link
Contributor

commented May 23, 2019

Thanks for the PR @sunshinejr.

This PR has been shipped in v1.5.6 - CHANGELOG.

@sunshinejr

This comment has been minimized.

Copy link
Member Author

commented May 23, 2019

hey @f-meloni no worries, happens to everyone! we had similar problems for Moya 12 where we had to do a quick 12.0.1 release 馃槄

@sunshinejr sunshinejr deleted the sunshinejr-patch-1 branch May 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can鈥檛 perform that action at this time.