Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix not to log in to shell twice #264

Merged
merged 2 commits into from Aug 23, 2019

Conversation

@manicmaniac
Copy link
Contributor

commented Aug 23, 2019

Currently ShellExecutor always invokes $SHELL with -l option but this causes unexpected reloading of .bash_profile, .zprofile, .bashrc, .zshrc and so on.

Basically danger-swift is designed as a command line tool and expected to run on login shell so -l option is unnecessary.

Especially, since .bash_profile or .zprofile is only loaded at login time, some people expects it to be loaded at only once in a login session.

Thus I removed -l option from ShellExecutor.

@f-meloni
Copy link
Member

left a comment

Thank you very much for the PR! :)
Can you please update the changelog file too?

@manicmaniac manicmaniac changed the title Fix not to login twice Fix not to log in to shell twice Aug 23, 2019

@manicmaniac

This comment has been minimized.

Copy link
Contributor Author

commented Aug 23, 2019

@f-meloni I've just added new change log entry for 2.0.2.

BTW it looks like 2.0.1 doesn't have its change log entry. Is it okay to skip the entry for 2.0.1?

@f-meloni

This comment has been minimized.

Copy link
Member

commented Aug 23, 2019

Thank you!
2.0.1 was released just to make Danger-Swift work with GitHub Actions, will add a changelog entry later :)

@f-meloni

This comment has been minimized.

Copy link
Member

commented Aug 23, 2019

Merge on green

@peril-staging peril-staging bot merged commit c62e1ed into danger:master Aug 23, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.