New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make commit author and committer optional #75

Merged
merged 2 commits into from May 27, 2018

Conversation

Projects
None yet
3 participants
@Sega-Zero
Copy link
Contributor

Sega-Zero commented May 27, 2018

Noticed that in some cases commits may loose author (when they pushed with the wrong email, for example).

had this in commits response and danger-swift failed to parse it:

{
    "sha": "124c29519f7bf5427f7898c321dad561e2443f36",
    "commit": {
      "author": {
        "name": "User",
        "email": "user@mail.com",
        "date": "2018-05-08T08:22:20Z"
      },
      "committer": {
        "name": "User",
        "email": "user@mail.com",
        "date": "2018-05-08T08:22:20Z"
      },
      "message": "...",
      "tree": {
        "sha": "206f9b31716726968de6a35c2ee19a1ada62e8e5",
        "url": "https://api.github.com/repos/company/repo/git/trees/206f9b31716726968de6a35c2ee19a1ada62e8e5"
      },
      "url": "https://api.github.com/repos/company/repo/git/commits/124c29519f7bf5427f7898c321dad561e2443f36",
      "comment_count": 0,
      "verification": {
        "verified": false,
        "reason": "unsigned",
        "signature": null,
        "payload": null
      }
    },
    "url": "https://api.github.com/repos/company/repo/commits/124c29519f7bf5427f7898c321dad561e2443f36",
    "html_url": "https://github.com/company/repo/commit/124c29519f7bf5427f7898c321dad561e2443f36",
    "comments_url": "https://api.github.com/repos/company/repo/commits/124c29519f7bf5427f7898c321dad561e2443f36/comments",
    "author": null,
    "committer": null,
    "parents": [
      {
        "sha": "9ecf478dbc6c95e2001642cc988b4e64eb4cea72",
        "url": "https://api.github.com/repos/company/repo/commits/9ecf478dbc6c95e2001642cc988b4e64eb4cea72",
        "html_url": "https://github.com/company/repo/commit/9ecf478dbc6c95e2001642cc988b4e64eb4cea72"
      }
    ]
  }

Just like #73 it's somehow related to #68 :)

@DangerCI

This comment has been minimized.

Copy link

DangerCI commented May 27, 2018

Warnings
⚠️

Any changes to library code should be reflected in the Changelog.

Please consider adding a note there and adhere to the Changelog Guidelines.

Generated by 🚫 dangerJS

@Sega-Zero Sega-Zero changed the title Make commit author optional Make commit author and committer optional May 27, 2018

@orta

This comment has been minimized.

Copy link
Member

orta commented May 27, 2018

👍

@orta orta merged commit d90a024 into danger:master May 27, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@peril-staging

This comment has been minimized.

Copy link
Contributor

peril-staging bot commented Jul 22, 2018

Thanks for the PR @Sega-Zero.

This PR has been shipped in v0.4.1 - CHANGELOG.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment