New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supports using the new url option for sub-processes #84

Merged
merged 7 commits into from Oct 20, 2018

Conversation

Projects
None yet
1 participant
@orta
Copy link
Member

orta commented Oct 7, 2018

This should fix #69 - but it requires shipping Danger JS 5.0

For now this is both backwards and future compatible on both sides, as it does both the url and the json and Danger JS supports listening for both the url and the JSON (but prioritizes the URL)

Docs will be shipped on the danger systems page for danger process.

@orta orta force-pushed the post_url_too branch from 3ca9b29 to 64ddb5d Oct 7, 2018

@orta orta force-pushed the post_url_too branch from 64ddb5d to d7b0d6a Oct 7, 2018

@orta orta force-pushed the post_url_too branch from f58c772 to 7551b1a Oct 7, 2018

orta added some commits Oct 7, 2018

@orta

This comment has been minimized.

Copy link
Member

orta commented Oct 20, 2018

Danger 5.0 is shipped

@orta orta merged commit 7904814 into master Oct 20, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment