New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Shellout files on the Makefile #91

Merged
merged 2 commits into from Oct 27, 2018

Conversation

Projects
None yet
2 participants
@f-meloni
Copy link
Member

f-meloni commented Oct 25, 2018

If you try to run danger-swift pr $PR and you are using the installed swift-danger (then you don't have the full .build folder) you get this error.

Danger: ⅹ Failing the build, there is 1 fail.

Dangerfile.swift:4:8: error: missing required module 'ShellOut'
import Danger
       ^

Not sure this is the best solution to the problem, but adding this and calling make install solved the problem in my case.

f-meloni added some commits Oct 25, 2018

@f-meloni

This comment has been minimized.

Copy link
Member

f-meloni commented Oct 25, 2018

Looks is having the same problem of #89

@orta

This comment has been minimized.

Copy link
Member

orta commented Oct 27, 2018

Interesting, I added some more debug logs to this repo and it's a tad worrying that it just doesn't echo anything :-/

@orta orta merged commit 62af7d4 into danger:master Oct 27, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment