New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple files import #93

Merged
merged 14 commits into from Nov 5, 2018

Conversation

Projects
None yet
3 participants
@f-meloni
Copy link
Member

f-meloni commented Nov 3, 2018

Opening this even if i still have to think to how to apply the canges to danger-swift edit just to get some early feedbacks, because the taken approach is different to the one suggested on #49.

@DangerCI

This comment has been minimized.

Copy link

DangerCI commented Nov 3, 2018

Warnings
⚠️

Big PR, try to keep changes smaller if you can

Generated by 🚫 dangerJS

@orta

This comment has been minimized.

Copy link
Member

orta commented Nov 4, 2018

Interesting!

Yeah, this looks 👍 to me

@orta

This comment has been minimized.

Copy link
Member

orta commented Nov 4, 2018

OK, I need to try figure out what's going on with these 10m launches :-/

orta added some commits Nov 4, 2018

@f-meloni

This comment has been minimized.

Copy link
Member

f-meloni commented Nov 4, 2018

Thanks :)
Will add the changelog in the meantime, to remove the warning

@orta

This comment has been minimized.

Copy link
Member

orta commented Nov 5, 2018

interesting, none of the logs got hit

@orta

This comment has been minimized.

Copy link
Member

orta commented Nov 5, 2018

I wonder if this is because it's using a globally installed version of danger-js

@orta

This comment has been minimized.

Copy link
Member

orta commented Nov 5, 2018

OK, yeah, that works - interesting. I'll merge this for now and have a think.

@orta orta merged commit 6a89350 into danger:master Nov 5, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@orta orta referenced this pull request Nov 5, 2018

Closed

Support importing another file #49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment