New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes in #254 introduced dependency on rust-crypto which block build for AARCH64 #262

Closed
mprasil opened this Issue Nov 20, 2018 · 6 comments

Comments

3 participants
@mprasil
Copy link
Collaborator

mprasil commented Nov 20, 2018

The transitive dependency introduced in this PR blocks aarch64 builds.

@mprasil mprasil added the bug label Nov 20, 2018

@dani-garcia

This comment has been minimized.

Copy link
Owner

dani-garcia commented Nov 21, 2018

rust-crypto is deprecated, we would need to have the yubico_rs crate migrated to something else. The recommendation in that thread is RustCrypto.

The easiest solution for now would be to put everything that uses the yubico_rs crate under a ´#[cfg(not(target_arch = "aarch64"))]`.

The best solution would obviously be to see if yubico_rs maintainer would accept a PR migrating to an alternative that is actively maintained, but I don't have the time available for it. So if someone wants to help with that, it would be greatly appreciated.

@mcrosson

This comment has been minimized.

Copy link

mcrosson commented Jan 10, 2019

@dani-garcia Would it be possible to have some kind of build option to turn off Yubikey support?

That would allow those of us on aarch64 the ability to build and run if not having Yubikey support is acceptable.

(I know I'd <3 to run bitwarden_rs and would gladly give up Yubikey support to be able to build/run)

@dani-garcia

This comment has been minimized.

Copy link
Owner

dani-garcia commented Jan 10, 2019

Yo are right, I planned on making youkey functionality optional a long time ago and forgot completely. Should be fixed now with 1d03474

@mcrosson

This comment has been minimized.

Copy link

mcrosson commented Jan 10, 2019

@dani-garcia it built on my end 👍 . Any chance you'd be willing to tag a release for those of us running builds on our own? I'd prefer to target your releases rather than master...

@dani-garcia

This comment has been minimized.

Copy link
Owner

dani-garcia commented Jan 10, 2019

Sure, I already had a release prepared as a draft for the last couple days, as it's been a month since the last release (and over 80 commits). Might as well do it now.

https://github.com/dani-garcia/bitwarden_rs/releases/tag/1.6.0

@mprasil

This comment has been minimized.

Copy link
Collaborator

mprasil commented Jan 14, 2019

This is now resolved.

@mprasil mprasil closed this Jan 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment