Repository navigation
Update workflows and enhance security - #5537
Conversation
dfunkt
left a comment
There was a problem hiding this comment.
Haven't had the chance to test these changes yet, just a quick surface look.
|
@dfunkt, i think those items are not correct. |
|
You can disregard my previous suggestions, completly forgot that I was checking the files with |
This commit updates the workflow files and also fixes some security issues which were reported by using zizmor https://github.com/woodruffw/zizmor Signed-off-by: BlackDex <black.dex@gmail.com>
227379b to
efb941b
Compare
Well, you made me thinking, and having some added security by setting no permissions at all for the whole workflow by default, and then setting it per job is probably a nice way of enforcing it everywhere. In that case, when forks still have a read-write token by default that is also a bit more hard to exploit there. |
|
I also run these workflows through https://rhysd.github.io/actionlint/ and they are also clean there. |
|
@BlackDex: |
Thanks, that might be a nice thing to add :) |
This commit updates the workflow files and also fixes some security issues which were reported by using zizmor https://github.com/woodruffw/zizmor Signed-off-by: BlackDex <black.dex@gmail.com>
This commit updates the workflow files and also fixes some security issues which were reported by using zizmor https://github.com/woodruffw/zizmor