Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aria expanded for radios with conditonal #654

Closed
gavinthomas-valtech opened this issue Jan 7, 2023 · 4 comments · Fixed by #695
Closed

aria expanded for radios with conditonal #654

gavinthomas-valtech opened this issue Jan 7, 2023 · 4 comments · Fixed by #695

Comments

@gavinthomas-valtech
Copy link

gavinthomas-valtech commented Jan 7, 2023

Adding aria expanded to conditionals in radios improves support for screenreaders knowing that the panel/info has been exposed

related issues:

w3c/aria#1404

alphagov/govuk-frontend#979

In March 2021, we spoke to a Lead Auditor at the Digital Accessibility Centre who works alongside screen reader testers and users with disabilities. They audit a lot of government services, especially HMRC services. As such, they're pretty familiar with the current approach to conditional reveals.

They mentioned that they’d known about the invalid use of aria-expanded for a while, but not really flagged it as it’s normally read by screen readers (at least the versions of JAWS and NVDA they test with, would have to check Voiceover).

Happy to try and create a PR for this

@gavinthomas-valtech
Copy link
Author

gov uk uses aria expanded on conditionals
https://design-system.service.gov.uk/components/radios/

@robpataki
Copy link
Contributor

@daniel-ac-martin
Copy link
Owner

Hi @gavinthomas-valtech.
Thanks for reminding me about this. We don't yet properly support conditional reveals on radios. If memory serves, there's some complication with implementing this in React while supporting isomorphic rendering. I'll have to have a look at how I did it for checkboxes. (Although handing the state is simpler there.)

@robpataki: Thanks for pointing out the discussion on this. Will be interesting to see if aria-expanded is kept in place.

At the very least, we should add aria-expanded to the Checkboxes.

@daniel-ac-martin
Copy link
Owner

@gavinthomas-valtech: This should be fixed in the next version (v0.6.0).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants