Memory Leak when using ConvenienceBuilder.createAppTitleItem()

[code-schreiber]

It seems when passing context to ConvenienceBuilder.createAppTitleItem() the activity instance is leaked.

Code to reproduce

    @NonNull
    @Override
    protected MaterialAboutList getMaterialAboutList(@NonNull Context context) {
        MaterialAboutCard card = new MaterialAboutCard.Builder()
                .addItem(ConvenienceBuilder.createAppTitleItem(context)) // This leaks the activity
                .build();
        
        return new MaterialAboutList.Builder()
                .addCard(card)
                .build();
    }

Leakcanary says

Now, from what I understand about it is this a known leak and affects JELLY_BEANup to MARSHMALLOW.

The way to easily avoid it in ConvenienceBuilder would be to pass the application context and not the activity directly.

[daniel-stoneuk]

Merged! Thank you.

[code-schreiber]

You are very welcome 😀