Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Suggestion: Align title and non-title elements #79
One of the first things that I noticed when creating an about screen with a
I tried to illustrate the issue with a screenshot where the blue lines belong to the title and the red ones to the action item.
I am aware that this is not going to be an issue for everyone but I believe this change will make many eyes happy
Good spot. I think I tried a couple different combinations but this was the most eye pleasing. Part of the issue is that the app icon may be wider than the one in the demo, in this case what will it look like.
I will mess around with different designs, post them here and we can decide on the best.
The "new" design looks very nice!
The only thing that I would consider changing is the spacing for the smaller icons, now it seems too big to left and right. I'm aware that the app icon is usually bigger and that influences the spacing of the whole screen, so my suggestion would be to reduce the spacing of both app and non-app icons.
Be aware that this is a breaking change in terms of design and it should be very clear for library consumers that their screens will potentially look a bit different after updating.
Yeah, I see what you mean.
If we did decrease the spacing of both types of icon, I believe that the title icon will be too near the edge of the card. This is assuming we want the action icon to be centered with the title icon.
It does seem like material design is heading towards more whitespace and the extra spacing doesn't feel too out of place. It definitely looks better than the original.
Good point about breaking changes. I'll make that clear.
After testing however, it doesn't look that bad with reduced title padding: