Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update number_to_phone/2 typespec #52

Merged
merged 1 commit into from Apr 15, 2023

Conversation

lleger
Copy link
Contributor

@lleger lleger commented Aug 25, 2021

The type spec indicated the function only took a number but it also accepts a string. This is expressed in the documentation and tested. This commit just updates the spec to reflect that.

The type spec indicated the function only took a `number` but it also accepts a string. This is expressed in the documentation and tested. This commit just updates the spec to reflect that.
@lleger
Copy link
Contributor Author

lleger commented Nov 2, 2021

@danielberkompas Any chance you can merge this? It's a quick PR that fixes a bug that cascades through our system, creating some painful Dialyzer experiences.

@edennis
Copy link

edennis commented Nov 25, 2022

Just bumping this again. @danielberkompas would it be possible to cut a patch-level release with this in it? 🙏🏻

@danielberkompas
Copy link
Owner

Yes, working on it now. 🌟 Thanks!

@danielberkompas danielberkompas merged commit cc2c580 into danielberkompas:master Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants