Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Global `viewGenerator` not been applied to the nodes #130

Closed
LonelyPrincess opened this issue Oct 13, 2018 · 2 comments
Assignees

Comments

@LonelyPrincess
Copy link
Collaborator

@LonelyPrincess LonelyPrincess commented Oct 13, 2018

The PR #103 changes introduced in the latest release (2.0.0-rc1) do seem to have a bug when being applied to real projects. If the user defines a viewGenerator in the config object, its value is completely ignored and the default view is used instead.

It seems as if the Node object receives viewGenerator as an undefined value, instead of receiving the generator function defined by the user in the config object. Things work fine if the viewGenerator is defined at node level, though.

For some reason, this error does not happen in the Sandbox example, which is why this issue wasn't detected before merging the feature into the main branch.

@LonelyPrincess

This comment has been minimized.

Copy link
Collaborator Author

@LonelyPrincess LonelyPrincess commented Oct 13, 2018

As the author of the changes, I'll make myself responsible for this and upload a fix for it ASAP. Sorry for the inconvenience! 馃槥

@danielcaldas

This comment has been minimized.

Copy link
Owner

@danielcaldas danielcaldas commented Oct 14, 2018

Closing with #131

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.