Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete (remove) nodes and links from graph #183

Closed
wendymungovan opened this issue Mar 14, 2019 · 4 comments · Fixed by #186
Closed

Delete (remove) nodes and links from graph #183

wendymungovan opened this issue Mar 14, 2019 · 4 comments · Fixed by #186
Labels
bug

Comments

@wendymungovan
Copy link

@wendymungovan wendymungovan commented Mar 14, 2019

Describe the bug
When you remove a node and associated links from the graph unless it is the last link in the list seemingly random links are removed.

To Reproduce
Steps to reproduce the behavior:

  1. Display a graph
  2. Delete a node (not the last added and all associated links)
    Incorrect links and nodes are removed from the graph.

My code is doing the same things as Sandbox onClickRemoveNode() but just for a selected node not the first node. The graph json that is being passed has correctly removed the links and nodes.

Environment:

  • Browser = chrome
  • react-d3-graph version = 2.0.0-rc2
@wendymungovan

This comment has been minimized.

Copy link
Author

@wendymungovan wendymungovan commented Mar 14, 2019

@danielcaldas

This comment has been minimized.

Copy link
Owner

@danielcaldas danielcaldas commented Mar 27, 2019

@grant37 submitted a PR that is looking very promising, will update this issue as soon as I run some tests on the open PR. #186 (review)

@danielcaldas

This comment has been minimized.

Copy link
Owner

@danielcaldas danielcaldas commented Mar 28, 2019

This was fixed with #186, will be published within the next release.

@danielcaldas

This comment has been minimized.

Copy link
Owner

@danielcaldas danielcaldas commented Mar 28, 2019

Thanks @grant37 for the PR! 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.