Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition to readme #190

Closed
M1sterPl0w opened this issue Apr 5, 2019 · 2 comments
Closed

Addition to readme #190

M1sterPl0w opened this issue Apr 5, 2019 · 2 comments
Labels

Comments

@M1sterPl0w
Copy link

@M1sterPl0w M1sterPl0w commented Apr 5, 2019

Hi,

First of all, thanks for creating this wonderful piece of software.
I am fairly new to React and I was trying to get your example working with the following steps:

  • npm install react-d3-graph
  • add Graph tag and call backs into a component.

After this I did get several error message that it was missing d3-drag, etc etc.
After a while I thought maybe I should install d3 (npm install d3), this action did the trick. Maybe you could add this to the readme? So it is more noob friendly?

Kind regards,

Jeroen

@danielcaldas

This comment has been minimized.

Copy link
Owner

@danielcaldas danielcaldas commented Apr 6, 2019

Hi there @M1sterPl0w! Thanks a lot for the input, that's right you need to install d3 and react yourself as they are peer-dependencies. This might not be very clear, I will update the README.md with this information.

@danielcaldas

This comment has been minimized.

Copy link
Owner

@danielcaldas danielcaldas commented Apr 6, 2019

Closing, README.md updated with #191

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.