Fixes for DTGridView #1

Merged
2 commits merged into from Oct 24, 2010

Conversation

Projects
None yet
2 participants
@aufflick
Contributor

aufflick commented Oct 21, 2010

Hi Daniel,

As promised, some fixes. Hopefully the commit comments make sense. They may not be the nicest way to fix the problems, so feel free to rework as desired.

Mark.

aufflick added some commits Oct 21, 2010

I found a bug in DTGridView where changes to the underlying data
don't become visible when you pop back to a DTGridView from a
subsequent navigation controller view.

What actually happens is that the changes are noticed -
addCellWithInfo is called for each cell, but the previous views are
not removed. So if I pop back and forth (making changes to the
underlying data each time) I see the subviews count continually
increase. Since the view is underneath the other views it is not
visible.

Adding a call to removeCellWithInfo for each addCell didn't work
because it seems that some entries in gridCells have lightweight info
objects even if the cell is visible on screen.

The fix to addCellWithInfo feels a little hacky, but given the small number of subviews
onscreen at any one time it will at least be fast.
@danielctull

This comment has been minimized.

Show comment Hide comment
@danielctull

danielctull Oct 21, 2010

Owner

Cheers for doing this Mark, hope it wasn't too much hassle. I'm going to pull this in over the weekend. It's also reminded me of another issue with unintentionally removing the scroll bars, because the scroll bars are a subview of the UIScrollView.

Owner

danielctull commented Oct 21, 2010

Cheers for doing this Mark, hope it wasn't too much hassle. I'm going to pull this in over the weekend. It's also reminded me of another issue with unintentionally removing the scroll bars, because the scroll bars are a subview of the UIScrollView.

@aufflick

This comment has been minimized.

Show comment Hide comment
@aufflick

aufflick Oct 21, 2010

Contributor

You know, I never noticed that, but you're right! I look forward to the fix ;)

Contributor

aufflick commented Oct 21, 2010

You know, I never noticed that, but you're right! I look forward to the fix ;)

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment