Skip to content
Commits on Nov 27, 2012
  1. @gwd

    libxl: Fix bug in libxl_cdrom_insert, make more robust against bad xe…

    …nstore data
    
    libxl_cdrom_insert was failing to initialize the backend type,
    resulting in the wrong default backend.  The result was not only that
    the CD was not inserted properly, but also that some improper xenstore
    entries were created, causing further block commands to fail.
    
    This patch fixes the bug by setting the disk backend type based on the
    type of the existing device.
    
    It also makes the system more robust by checking to see that it has
    got a valid path before proceeding to write a partial xenstore entry.
    
    Signed-off-by: George Dunlap <george.dunlap@eu.citrix.com>
    Acked-by: Ian Campbell <ian.campbell@citrix.com>
    Committed-by: Ian Campbell <ian.campbell@citrix.com>
    gwd committed Nov 27, 2012
  2. xl: xl.conf(5): correct advice re autoballooning vs. dom0_mem.

    The advice was backwards, you should really disable autoballoon if you
    use dom0_mem. Also add a reference to the command-line docs.
    
    Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
    Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
    Committed-by: Ian Campbell <ian.campbell@citrix.com>
    Ian Campbell committed Nov 27, 2012
  3. README: add Pixman as build dependency

    Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
    Acked-by: Ian Campbell <ian.campbell@citrix.com>
    Committed-by: Ian Campbell <ian.campbell@citrix.com>
    Stefano Stabellini committed Nov 27, 2012
  4. libxl: fix a variable underflow in libxl_wait_for_free_memory

    When xl is called to create a domU and there is not enough memory available,
    then the autoballooning is called to extract memory from dom0. During the
    ballooning a loop in libxl_wait_for_free_memory() waits unless enough memory
    is available to create the domU.
    
    But because of a variable-underflow the loop can finish too soon and xl
    finally aborts with the message:
    
    xc: error: panic: xc_dom_boot.c:161: xc_dom_boot_mem_init: can't allocate low memory for domain: Out of memory
    libxl: error: libxl_dom.c:430:libxl__build_pv: xc_dom_boot_mem_init failed: Device or resource busy
    libxl: error: libxl_create.c:901:domcreate_rebuild_done: cannot (re-)build domain: -3
    
    The variable-underflow happens when freemem_slack is larger then
    info.free_pages*4, because the solution of this operation is converted
    implicit to a unsigned int to match the type of memory_kb.
    
    Add a extra check for this condition to solve the problem.
    
    Signed-off-by: Ronny Hegewald <Ronny.Hegewald@online.de>
    Acked-by: Ian Campbell <ian.campbell@citrix.com>
    Committed-by: Ian Campbell <ian.campbell@citrix.com>
    Ronny Hegewald committed Nov 27, 2012
  5. @chunyanliu

    xenstore-chmod: handle arbitrary number of perms rather than MAX_PERM…

    …S constant
    
    Constant MAX_PERMS 16 is too small to use in some occasions, e.g. if
    there are more than 16 domU(s) on one hypervisor (it's easy to
    achieve) and one wants to do xenstore-chmod PATH to all domU(s). So,
    remove MAX_PERMS limitation and make it as arbitrary number of perms.
    
    Signed-off-by: Chunyan Liu <cyliu@suse.com>
    Acked-by: Ian Campbell <ian.campbell@citrix.com>
    Committed-by: Ian Campbell <ian.campbell@citrix.com>
    chunyanliu committed Nov 27, 2012
Commits on Nov 26, 2012
  1. @jbeulich

    x86/time: fix scale_delta() inline assembly

    The way it was coded, it clobbered %rdx without telling the compiler.
    This generally didn't cause any problems except when there are two back
    to back invocations (as in plt_overflow()), as in that case the
    compiler may validly assume that it can re-use for the second instance
    the value loaded into %rdx before the first one.
    
    Once at it, also properly relax the second operand of "mul" (there's no
    need for it to be in %rdx, or a register at all), and switch away from
    using explicit register names in the instruction operands.
    
    Signed-off-by: Jan Beulich <jbeulich@suse.com>
    Acked-by: Keir Fraser <keir@xen.org>
    jbeulich committed Nov 26, 2012
Commits on Nov 23, 2012
  1. @olafhering

    xend: enable environment passing in xPopen3

    In changeset 19990:38dd208e1d95 a new parameter 'env' was added to
    xPopen3, but no code was added to actually pass the environment down to
    execvpe. Also, the new code was unreachable.
    
    Signed-off-by: Olaf Hering <olaf@aepfle.de>
    Acked-by: Ian Campbell <ian.campbell@citrix.com>
    Committed-by: Ian Campbell <ian.campbell@citrix.com>
    olafhering committed Nov 23, 2012
  2. arm: Tidy up flush_xen_dcache().

     - Use a compile-time-constant check for whether we can safely flush
       just one cacheline.  This reduces the common case from 28
       instructions to three.
     - Pass an object to the macro, not a pointer, so we can detect
       attempts to flush arrays.
     - Decode CCSIDR correctly to get cacheline size.
     - Remove some redundant DSBs at the call sites.
    
    Signed-off-by: Tim Deegan <tim@xen.org>
    Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
    Committed-by: Ian Campbell <ian.campbell@citrix.com>
    Tim Deegan committed Nov 23, 2012
  3. @gwd

    xl: Suppress spurious warning message for cpupool-list

    libxl_cpupool_list() enumerates the cpupools by "probing": calling
    cpupool_info, starting at 0 and stopping when it gets an error. However,
    cpupool_info will print an error when the call to xc_cpupool_getinfo() fails,
    resulting in every xl command that uses libxl_list_cpupool (such as
    cpupool-list) printing that error message spuriously.
    
    Since at the moment the times we want to print the message correspond
    with the use of the existing "exact" parameter, use it to decide
    whether to print the message or not.
    
    Signed-off-by: George Dunlap <george.dunlap@eu.citrix.com>
    Acked-by: Ian Campbell <ian.campbell@citrix.com>
    Committed-by: Ian Campbell <ian.campbell@citrix.com>
    gwd committed Nov 23, 2012
Commits on Nov 22, 2012
  1. @jbeulich

    implement vmap()

    ... and use it as basis for a proper ioremap() on x86.
    
    Signed-off-by: Jan Beulich <jbeulich@suse.com>
    Acked-by: Keir Fraser <keir@xen.org>
    jbeulich committed Nov 22, 2012
  2. @jbeulich

    x86/HPET: fix FSB interrupt masking

    HPET_TN_FSB is not really suitable for masking interrupts - it merely
    switches between the two delivery methods. The right way of masking is
    through the HPET_TN_ENABLE bit (which really is an interrupt enable,
    not a counter enable or some such). This is even more so with certain
    chip sets not even allowing HPET_TN_FSB to be cleared on some of the
    channels.
    
    Further, all the setup of the channel should happen before actually
    enabling the interrupt, which requires splitting legacy and FSB logic.
    
    Finally this also fixes an S3 resume problem (HPET_TN_FSB did not get
    set in hpet_broadcast_resume(), and hpet_msi_unmask() doesn't get
    called from the general resume code either afaict).
    
    Signed-off-by: Jan Beulich <jbeulich@suse.com>
    Acked-by: Keir Fraser <keir@xen.org>
    jbeulich committed Nov 22, 2012
  3. @jbeulich

    x86/HPET: include FSB interrupt information in 'M' debug key output

    Signed-off-by: Jan Beulich <jbeulich@suse.com>
    Acked-by: Keir Fraser <keir@xen.org>
    jbeulich committed Nov 22, 2012
  4. @jbeulich

    VT-d: clean up map/unmap log messages

    - printing file name and line number here is pointless
    - they are guest related, so should get their log level filter
      accordingly
    - include segment numbers and canonicalize number widths
    
    Signed-off-by: Jan Beulich <jbeulich@suse.com>
    jbeulich committed Nov 22, 2012
Commits on Nov 20, 2012
  1. xend: reinstate XendOptionsFile.get_external_migration_tool

    This was removed by 26167:31dcc0e08754 "xend: Remove old vtpm support
    from xm" but at least one caller was left. Reinstate with
    s/TPM/device/ since it appears that this functionality could apply
    elsewhere.
    
    Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
    Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
    Committed-by: Ian Campbell <ian.campbell@citrix.com>
    Ian Campbell committed Nov 20, 2012
  2. @jbeulich

    passthrough/PCI: replace improper uses of pci_find_next_cap()

    Using pci_find_next_cap() without prior pci_find_cap_offset() is bogus
    (and possibly wrong, given that the latter doesn't check the
    PCI_STATUS_CAP_LIST flag, which so far was checked in an open-coded way
    only for the non-bridge case).
    
    Once at it, fold the two calls into one, as we need its result in any
    case.
    
    Question is whether, without any caller left, pci_find_next_cap()
    should be purged as well.
    
    Signed-off-by: Jan Beulich <jbeulich@suse.com>
    Acked-by: Xiantao Zhang <xiantao.zhang@intel.com>
    jbeulich committed Nov 20, 2012
Commits on Nov 19, 2012
  1. xen: fix build failure due to extra closing comment

    Added by 26173:26facad2f1a1
    
    Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
    Committed-by: Ian Campbell <ian.campbell@citrix.com>
    Ian Campbell committed Nov 19, 2012
  2. docs: Include prototype for HYPERVISOR_multicall

    Mark-up for inclusion of generated docs.
    
    Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
    Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
    Committed-by: Ian Campbell <ian.campbell@citrix.com>
    Ian Campbell committed Nov 19, 2012
  3. docs: Document HYPERVISOR_update_descriptor

    Mark-up for inclusion of generated docs.
    
    Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
    Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
    Committed-by: Ian Campbell <ian.campbell@citrix.com>
    Ian Campbell committed Nov 19, 2012
  4. docs: Add ToC entry for start of day memory layout.

    Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
    Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
    Committed-by: Ian Campbell <ian.campbell@citrix.com>
    Ian Campbell committed Nov 19, 2012
  5. docs: Document HYPERVISOR_mmuext_op

    Mark-up for inclusion of generated docs.
    
    Remove some trailing whitespace.
    
    Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
    Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
    Committed-by: Ian Campbell <ian.campbell@citrix.com>
    Ian Campbell committed Nov 19, 2012
  6. docs: document HYPERVISOR_update_va_mapping(_other_domain)

    Mark-up for inclusion of generated docs.
    
    Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
    Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
    Committed-by: Ian Campbell <ian.campbell@citrix.com>
    Ian Campbell committed Nov 19, 2012
  7. docs: document/mark-up SCHEDOP_*

    The biggest subtlety here is there additional argument when op ==
    SCHEDOP_shutdown and reason == SHUTDOWN_suspend and its interpretation by
    xc_domain_{save,restore}. Add some clarifying comments to libxc as well.
    
    This patch moves some structs around but there is no functional change
    other than improved documentation.
    
    Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
    Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
    Committed-by: Ian Campbell <ian.campbell@citrix.com>
    Ian Campbell committed Nov 19, 2012
  8. @jbeulich

    AMD IOMMU: fix type of "bdf" parameter of update_intremap_entry_from_…

    …msi_msg()
    
    Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
    Signed-off-by: Jan Beulich <jbeulich@suse.com>
    jbeulich committed Nov 19, 2012
  9. Remove tools/vtpm* from MAINTAINERS file

    Signed-off-by: Matthew Fioravante <matthew.fioravante@jhuapl.edu>
    Acked-by: Ian Campbell <ian.campbell@citrix.com>
    Committed-by: Ian Campbell <ian.campbell@citrix.com>
    Matthew Fioravante committed Nov 19, 2012
  10. tools: Remove old vtpm stuff from tools/libxen

    Signed-off-by: Matthew Fioravante <matthew.fioravante@jhuapl.edu>
    Acked-by: Ian Campbell <ian.campbell@citrix.com>
    Committed-by: Ian Campbell <ian.campbell@citrix.com>
    Matthew Fioravante committed Nov 19, 2012
  11. Remove VTPM_TOOLS from config/Tools.mk.in

    Signed-off-by: Matthew Fioravante <matthew.fioravante@jhuapl.edu>
    Acked-by: Ian Campbell <ian.campbell@citrix.com>
    Committed-by: Ian Campbell <ian.campbell@citrix.com>
    Matthew Fioravante committed Nov 19, 2012
  12. xend: Remove old vtpm support from xm

    Signed-off-by: Matthew Fioravante <matthew.fioravante@jhuapl.edu>
    Acked-by: Ian Campbell <ian.campbell@citrix.com>
    Committed-by: Ian Campbell <ian.campbell@citrix.com>
    Matthew Fioravante committed Nov 19, 2012
  13. minios: Update mini-os license to support GPL features

    This patch updates extras/mini-os/COPYING to explain
    which optional features are GPL and what the implications
    of enabling them are.
    
    Signed-off-by: Matthew Fioravante <matthew.fioravante@jhuapl.edu>
    Acked-by: Ian Campbell <ian.campbell@citrix.com>
    Committed-by: Ian Campbell <ian.campbell@citrix.com>
    Matthew Fioravante committed Nov 19, 2012
  14. minios: fix bug in lseek for mini-os

    lseek always used files[fd].file.offset. It should
    use the offset of whatever union member is actually
    being used.
    
    Signed-off-by: Matthew Fioravante <matthew.fioravante@jhuapl.edu>
    Acked-by: Ian Campbell <ian.campbell@citrix.com>
    Committed-by: Ian Campbell <ian.campbell@citrix.com>
    Matthew Fioravante committed Nov 19, 2012
  15. xen/arm: get the number of cpus from device tree

    The system might have fewer cpus than the GIC supports.
    
    Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
    Acked-by: Ian Campbell <ian.campbell@citrix.com>
    Committed-by: Ian Campbell <ian.campbell@citrix.com>
    Stefano Stabellini committed Nov 19, 2012
  16. xen/arm: flush D-cache and I-cache when appropriate

    - invalidate tlb after setting WXN
    - flush D-cache and I-cache after relocation;
    - invalidate D-cache after writing to smp_up_cpu;
    - flush I-cache after changing HTTBR;
    - flush I-cache and branch predictor after writing Xen text ptes.
    
    Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
    Acked-by: Ian Campbell <ian.campbell@citrix.com>
    Committed-by: Ian Campbell <ian.campbell@citrix.com>
    Stefano Stabellini committed Nov 19, 2012
  17. @jbeulich

    vscsiif: minor cleanup

    Remove a definition not belonging into the interface, and correct a
    few typos in comments.
    
    Signed-off-by: Jan Beulich <jbeulich@suse.com>
    Acked-by: Keir Fraser <keir@xen.org>
    jbeulich committed Nov 19, 2012
  18. AMD IOMMU: Enable HPET broadcast msi remapping

    This patch enables hpet msi remapping for amd iommu.
    
    Signed-off-by: Wei Wang <wei.wang2@amd.com>
    
    - use the existing ACPI_IVHD_* #define-s
    - warn on finding more than one IVHD HPET entry
    - consolidate parameters of update_intremap_entry_from_msi_msg()
    
    Signed-off-by: Jan Beulich <jbeulich@suse.com>
    Committed-by: Jan Beulich <jbeulich@suse.com>
    Wei Wang committed Nov 19, 2012
Commits on Nov 15, 2012
  1. xen/arm: wake up secondary cpus

    Secondary cpus are held by the firmware until we send an IPI to them.
    
    Reordered non-boot cpu wait loop to perform the check before waiting
    for an event, to handled the case where the event has already
    happened when we reach the loop.
    
    Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
    Acked-by: Ian Campbell <ian.campbell@citrix.com>
    Committed-by: Ian Campbell <ian.campbell@citrix.com>
    Stefano Stabellini committed Nov 15, 2012
  2. xen/arm: set the SMP bit in the ACTLR register

    "Enables the processor to receive instruction cache, BTB, and TLB maintenance
    operations from other processors"
    
    ...
    
    "You must set this bit before enabling the caches and MMU, or
    performing any cache and TLB maintenance operations. The only time
    you must clear this bit is during a processor power-down sequence"
    
    Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
    Acked-by: Tim Deegan <tim@xen.org>
    Committed-by: Ian Campbell <ian.campbell@citrix.com>
    Stefano Stabellini committed Nov 15, 2012
Something went wrong with that request. Please try again.