Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port Nassl/SSLyze to upstream #6

Open
veehaitch opened this issue Jun 24, 2020 · 7 comments
Open

Port Nassl/SSLyze to upstream #6

veehaitch opened this issue Jun 24, 2020 · 7 comments

Comments

@veehaitch
Copy link

Hey there! Thanks for this useful project.

Internally, TLS Profiler uses a fork of Nassl and SSLyze. Do you have any plans on bringing your extensions for TLS Profiler into upstream Nassl/SSLyze?

@veehaitch
Copy link
Author

Please allow me to draw your attention to this issue again, @danielfett and @fabian-hk. Thank you!

@fabian-hk
Copy link
Contributor

Hey, sorry for the late reply. There are already pull requests submitted to nassl #58 and SSLyze #410 but the maintainer of these packages did not yet review them.

@veehaitch
Copy link
Author

No worries and thanks for your response!

Looks like those PRs have conflicts since they have been open for some time already. Would you be willing to rebase your changes for both PRs?

I'm currently working on bringing Tlsprofiler support to nixpkgs: NixOS/nixpkgs#91380. To that end, it would be very useful to have the required Nassl/SSLyze feature available upstream. I guess, this would also ease Tlsprofiler packaging in a general sense.

Feel free to reach out if you need any support.

@fabian-hk
Copy link
Contributor

I think the nassl branch should be easy to fix but the SSLyze part is probably a little bit more complicated. I will look into it.

@veehaitch
Copy link
Author

Thank you!

@unl1k3ly
Copy link

up !

@fabian-hk
Copy link
Contributor

@veehaitch @unl1k3ly I just wanted you to know that I have updated the TLSProfiler to support sslyze 3.1.0: PR #8. Sslyze 3.1.0 has the problem that it does not output the full server cipher suite order preference: Issue: #338. But this should be fixed in the next version 3.1.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants