Add Objective-c compatible for turning off drag in X and Y Axis separately #3421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3421 +/- ##
=========================================
Coverage ? 29.21%
=========================================
Files ? 117
Lines ? 13303
Branches ? 0
=========================================
Hits ? 3886
Misses ? 9417
Partials ? 0
Continue to review full report at Codecov.
|
|
@liuxuan30 no, not a regression. Originally you couldn't turn of x & y independently. When that feature was added, it was never exposed to objective-c |
FreddyZeng
added a commit
to FreddyZeng/Charts
that referenced
this pull request
May 11, 2018
* 'master' of https://github.com/danielgindi/Charts: Fix broken demo link in readme (ChartsOrg#3440) update candle chart view options in demo project to toggle showing candle bar (ChartsOrg#3424) add seperator set drag for x axis and y axis for Objective-c (ChartsOrg#3421)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals ⚽
Currently, turning off drag in X and Y Axis separately is only available for Swift.
This PR adds objective-c compatible for enabling/disabling drag in either axis separately.
Implementation Details 🚧
Add
@objctag fordragXEnabled,dragYEnabledproperties.