Daniel Naber danielnaber

Organizations

@languagetool-org
@danielnaber
  • @danielnaber 3289485
    [de] extend rules PRAEP_GEN, BEI_OHNE_DATIV
@danielnaber
@danielnaber

If Configuration gets used in the command-line project, it should probably be moved to languagetool-core, as it's not GUI-specific then anymore.

@danielnaber

Configuration isn't used in the command-line project, it's in a different project that's not a dependency of the command-line project.

@danielnaber

I think it should be "as much as you can", but a native speaker should comment on that.

@danielnaber
@danielnaber

I don't think "as more as possible" is correct, see e.g. see http://forum.wordreference.com/threads/as-more-as-possible.1912477/

@danielnaber
  • @danielnaber daca81e
    [en] fix false alarm for e.g. "I had curry and rice last night"
  • @danielnaber 7e69927
    [en] fix false alarm for "These can range from ..."
  • 1 more commit »
@danielnaber
  • @danielnaber b4d43e0
    [en] new rule "They had play", by PeterLawrence
@danielnaber
@danielnaber
Update disambiguation.xml
@danielnaber
Update EnglishWordRepeatRule.java
@danielnaber

Thanks, I've simplified the patch a bit (only one posIsIn() method) and committed it.

@danielnaber
  • @danielnaber e87c8f5
    [en] avoid false alarm on e.g. "The can can hold the water", based on…
@danielnaber
@danielnaber

I get syntax errors because of the <and> in the XML, but when I remove that I get this in EnglishDisambiguationRuleTest: CAN_WILL_MD:1 can[can/MD,c…

@danielnaber

I cannot see any new pull request at https://github.com/languagetool-org/languagetool/pulls

@danielnaber
EnglishWordRepeatRule.java
@danielnaber

This test fails for me: assertGood("The can can hold the water."), I guess disambiguation.xml needs to be modified, too? Then it should be part of …

@danielnaber
  • @danielnaber babcc4f
    [de] prohibit compounds that are (probably) wrong; enable use of suff…
@danielnaber

A switch might be a good idea. It currently doesn't have priority for me though, so a pull request might speed things up a lot.

@danielnaber
  • @danielnaber 15bf27c
    [de] adding words suggested by users
@danielnaber

Please have a look at https://github.com/languagetool-org/languagetool/pull/264/files for a proper pull request: it should only contain the changes…

@danielnaber

There's documentation at https://help.github.com/articles/using-pull-requests/, starting with "Before you begin".

@danielnaber
standalone detects errors but standalone fails
@danielnaber

The command line version doesn't consider the configuration of the GUI, that would be too confusing (e.g. scripts suddenly failing because the conf…

@danielnaber

I cannot properly use the pull request that way, could you use the latest source directly from github?

@danielnaber

Thanks!

@danielnaber