From 2ffeaf0110bf3fc84ed95d5d130f2259e2d51e4c Mon Sep 17 00:00:00 2001
From: danielpalme <daniel.palme@gmx.de>
Date: Sat, 29 Aug 2020 10:59:53 +0200
Subject: [PATCH] #363: Fixed OpenCover file handling (not unique tracked
 methods)

---
 src/Readme.txt                                |  1 +
 .../Parser/OpenCoverParser.cs                 | 22 +++++++++++++++++--
 .../Properties/Resources.Designer.cs          |  9 ++++++++
 .../Properties/Resources.resx                 |  3 +++
 4 files changed, 33 insertions(+), 2 deletions(-)

diff --git a/src/Readme.txt b/src/Readme.txt
index b08d014f..07fd5302 100644
--- a/src/Readme.txt
+++ b/src/Readme.txt
@@ -65,6 +65,7 @@ CHANGELOG
 
 4.6.5.0
 
+    * Fix: #363: Fixed OpenCover file handling (not unique tracked methods)
     * Fix: #371: Fixed order of metrics
 
 4.6.4.0
diff --git a/src/ReportGenerator.Core/Parser/OpenCoverParser.cs b/src/ReportGenerator.Core/Parser/OpenCoverParser.cs
index e012a714..d7bd69e9 100644
--- a/src/ReportGenerator.Core/Parser/OpenCoverParser.cs
+++ b/src/ReportGenerator.Core/Parser/OpenCoverParser.cs
@@ -73,8 +73,26 @@ public ParserResult Parse(XContainer report)
                 .Where(m => m.Attribute("skippedDueTo") == null)
                 .ToArray();
             var files = report.Descendants("File").ToArray();
-            var trackedMethods = report.Descendants("TrackedMethod")
-                .ToDictionary(t => t.Attribute("uid").Value, t => t.Attribute("name").Value);
+
+            var trackedMethods = new Dictionary<string, string>();
+
+            foreach (var trackedMethodElement in report.Descendants("TrackedMethod"))
+            {
+                if (trackedMethods.ContainsKey(trackedMethodElement.Attribute("uid").Value))
+                {
+                    Logger.WarnFormat(
+                        Resources.ErrorNotUniqueTrackedMethodUid,
+                        trackedMethodElement.Attribute("name").Value);
+
+                    trackedMethods.Clear();
+
+                    break;
+                }
+                else
+                {
+                    trackedMethods.Add(trackedMethodElement.Attribute("uid").Value, trackedMethodElement.Attribute("name").Value);
+                }
+            }
 
             var assemblyNames = modules
                 .Select(m => m.Element("ModuleName").Value)
diff --git a/src/ReportGenerator.Core/Properties/Resources.Designer.cs b/src/ReportGenerator.Core/Properties/Resources.Designer.cs
index 50b1a214..b43822b7 100644
--- a/src/ReportGenerator.Core/Properties/Resources.Designer.cs
+++ b/src/ReportGenerator.Core/Properties/Resources.Designer.cs
@@ -258,6 +258,15 @@ internal class Resources {
             }
         }
         
+        /// <summary>
+        ///   Looks up a localized string similar to The &apos;uid&apos; of tracked method &apos;{0}&apos; is not unique. Ignoring tracked methods..
+        /// </summary>
+        internal static string ErrorNotUniqueTrackedMethodUid {
+            get {
+                return ResourceManager.GetString("ErrorNotUniqueTrackedMethodUid", resourceCulture);
+            }
+        }
+        
         /// <summary>
         ///   Looks up a localized string similar to PartCover is no longer supported. If you want to generate coverage reports based on PartCover, please use version 3.x of ReportGenerator..
         /// </summary>
diff --git a/src/ReportGenerator.Core/Properties/Resources.resx b/src/ReportGenerator.Core/Properties/Resources.resx
index 23d86c56..6a90f285 100644
--- a/src/ReportGenerator.Core/Properties/Resources.resx
+++ b/src/ReportGenerator.Core/Properties/Resources.resx
@@ -183,6 +183,9 @@
   <data name="ErrorInvalidDotCoverReport" xml:space="preserve">
     <value>The dotCover report does not contain line coverage data. Use the dotCover command line parameter '/ReportType=DetailedXML' to capture line coverage.</value>
   </data>
+  <data name="ErrorNotUniqueTrackedMethodUid" xml:space="preserve">
+    <value>The 'uid' of tracked method '{0}' is not unique. Ignoring tracked methods.</value>
+  </data>
   <data name="ErrorPartCover" xml:space="preserve">
     <value>PartCover is no longer supported. If you want to generate coverage reports based on PartCover, please use version 3.x of ReportGenerator.</value>
   </data>