Resolve #12 temporarily

[andylizf]

No description provided.

[danielpinto8zz6]

it only works for windows?

[andylizf]

I think all this project only works on Windows now, actually.

[andylizf]

There's no "start" command in Linux or Mac. And judging which terminal available is difficult.

[danielpinto8zz6]

Sorry, I've been busy, I'll merge that soon as possible.
Thanks

[danielpinto8zz6]

so, I came up with an idea, vscode has the following settings :

// Customizes which terminal to run on Linux.
"terminal.external.linuxExec": "xterm",

// Customizes which terminal application to run on macOS.
"terminal.external.osxExec": "Terminal.app",

// Customizes which terminal to run on Windows.
"terminal.external.windowsExec": "C:\Windows\System32\cmd.exe"

so, we can use that setting to get the terminal and that way we can support all platforms

[andylizf]

I also thought of this idea. But Linux itself doesn't have a "start" command, and how to implement the "start" command is terminal emulators' own business. We can't always know which option can create a new instance. For example, zsh requires -t, gnome-terminal requires -x, and even some strange terminals don't have this feature at all. It depends on itself.

[danielpinto8zz6]

well, I already found a way xD
gnome-terminal -e 'sh -c "echo test; read -n1 -p "Press any key to continue...""'

[andylizf]

But if I use xterm and I haven't gnome-terminal?

[danielpinto8zz6]

It works too

[andylizf]

But it isn't "-e", it's another option in xterm.

[danielpinto8zz6]

I tested myself... Im linux user

[andylizf]

Cover my face. 😅 Very Embarrassing.

[danielpinto8zz6]

So, for mac I dont know, because I cant test xd

[andylizf]

Ok……

[andylizf]

So it is ${terminalConfiguration.get<string>("linuxExec")} -e 'sh -c "${command}; read -n1 -p "Press any key to continue...""'

[andylizf]

In fact, I already made what you say yesterday, but it's not consummate, which has not been completely successful on my classmate's ubuntu virtual machine.

so, I came up with an idea, vscode has the following settings :

// Customizes which terminal to run on Linux.
"terminal.external.linuxExec": "xterm",
// Customizes which terminal application to run on macOS.
"terminal.external.osxExec": "Terminal.app",
// Customizes which terminal to run on Windows.
"terminal.external.windowsExec": "C:\Windows\System32\cmd.exe"

so, we can use that setting to get the terminal and that way we can support all platforms

[danielpinto8zz6]

So, we have to rework that,
like, we don't need to use the vscode terminal, if we're launching os specific console we shouldn't call vscode terminal, we can do it by spawn command...
for mac I saw that we can make it work with osascript, I have no way to test it

[andylizf]

I think the opposite is true. We can change the settings, just like the JS template string lets the user set the command with variables. Like you said
"c-cpp-compile-run.run-command" = "gnome-terminal -e 'sh -c "${outputFile}; read -n1 -p "Press any key to continue...""'"
Then we getSetting<string>(key.runCommand).replace("${outputFile}", outputFile) and run again.

[andylizf]

I will implement it in the dev branch, in the foreseeable future...
And I think this can be merged to master to fix #12 temporarily.

[danielpinto8zz6]

Yes agree

[danielpinto8zz6]

f178b9d needs to be tested in windows & mac.
actually on linux it only supports gnome terminal and xterm

[danielpinto8zz6]

7be5d73

[danielpinto8zz6]

Confirmed working on linux & windows, still need to be tested on mac

[LazyRen]

Hi, I'm currently using this plugin in mac environment. Sadly current version does not works for external Terminal app. I created pull request to fix it. Hope it helps!

p.s. It only works for Terminal.app. 'iTerm' is not supported.