New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Help needed] Increase link area in documents listing #344

Merged
merged 1 commit into from May 20, 2018

Conversation

Projects
None yet
2 participants
@erikarvstedt
Contributor

erikarvstedt commented Apr 26, 2018

Increase the link area to include the whole visual header.

Fixes #335

This is not an ideal solution because it

  1. requires Javascript
  2. doesn't endow the header with link semantics, so, for example, the browser won't show a link preview on mouseover.

Maybe someone well-versed in CSS can (later) figure out a better approach.

Edit:
I've just added WIP to the title as I noticed that the onclick handler is erroneously triggered when the checkbox is clicked.
Is there a web dev out there who can help me finish this PR? 馃槬 馃槈

@erikarvstedt erikarvstedt changed the title from Increase link area in documents listing to WIP: Increase link area in documents listing Apr 26, 2018

@danielquinn

This comment has been minimized.

Owner

danielquinn commented Apr 28, 2018

The hack you added to the Python part is a special bit of beautiful hackery. I love it. It's hack in a file already full of hacks, so I have to hate it, but I still love it. Just please put constants like EXTRACT_URL at the top of the file (after imports, before functions) just for consistency of style.

As for front-end stuff, I'm afraid I suck at that stuff (but you know that). You might have better luck wrapping the text inside the .info block with a link of its own and styling that link to have a fixed height / width or maybe fiddling with a padding: value.

@erikarvstedt

This comment has been minimized.

Contributor

erikarvstedt commented May 3, 2018

I've moved the constant definition.
Since I'm writing very little Python day-to-day, even small hints about style and idioms are super helpful. Please never hesitate to correct me!

@erikarvstedt erikarvstedt changed the title from WIP: Increase link area in documents listing to WIP, help needed: Increase link area in documents listing May 3, 2018

@erikarvstedt erikarvstedt changed the title from WIP, help needed: Increase link area in documents listing to [WIP, help needed] Increase link area in documents listing May 3, 2018

Increase link area in documents listing
Increase the link area to include the whole visual header.

Fixes #335

@erikarvstedt erikarvstedt changed the title from [WIP, help needed] Increase link area in documents listing to [help needed] Increase link area in documents listing May 11, 2018

@erikarvstedt erikarvstedt changed the title from [help needed] Increase link area in documents listing to [Help needed] Increase link area in documents listing May 11, 2018

@danielquinn danielquinn merged commit ac0cda8 into danielquinn:master May 20, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on master at 63.648%
Details
@danielquinn

This comment has been minimized.

Owner

danielquinn commented May 20, 2018

I've had a lot on my plate these last few weeks, and I'm finally getting around to Paperless again. Thanks for your patience :-)

@erikarvstedt

This comment has been minimized.

Contributor

erikarvstedt commented May 20, 2018

@danielquinn , thanks for picking up working on Paperless again, it's highly appreciated! 鉂わ笍
Alas, the merge was a bit premature, since the PR wasn't yet finished (the onclick handler still triggers when clicking the checkbox.)
I'll dig into CSS and figure out how to do this properly. I'll post a fix tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment