fix: add support for vite-ssg with process.env.VITE_SSG
#220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
danielroe
changed the title
process.env.VITE_SSG
danielroe
approved these changes
Apr 5, 2022
Owner
danielroe
left a comment
danielroe
left a comment
There was a problem hiding this comment.
Looks like a reasonable solution. I imagine in most places where we're consuming vue-sanity there would be a browser polyfill for process.env.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vite SSG does not set any
$isServervariable to detect if it should server render, so this should do it fine!https://github.com/antfu/vite-ssg/blob/0be88a5e14aeb9fe1c518642f5f72c99fc5bbfc7/src/node/build.ts#L77