-
-
Notifications
You must be signed in to change notification settings - Fork 5
feat: upgrade to zero v0.18 #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎
|
|
Feel free to add me as a reviewer when you do these things |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks
… one Let's see if I can one-shot this from my phone
|
@arv @danielroe this should be ready to merge now |
|
apologies! please do ping me whenever you want me to see; I don't always get notified when a PR is opened (will need to somehow fix the github notifications 🤔) |
This PR makes
zero-vuecompatible with Zero v0.18. The following has been changed:useQuery.createSchemawithout versionnumber.#refCountMapinVueView, since theapplyChangefunction withRefCountMaphas been deprecated.@rocicorp/zero/advancedwith@rocicorp/zerouseQueryandVueView, based on the tests for Solid.Notes:
useQueryhas methods to keep track of the RefCount. If I understand v0.1.2 is not compatible with zero 0.17 #48 correctly, we don't need to do anything along those lines from zero 0.18 onwards. Is that correct?Closes:
useQueryandVueView#12