Skip to content

Conversation

@maxstevens-nl
Copy link
Collaborator

@maxstevens-nl maxstevens-nl commented Apr 4, 2025

This PR makes zero-vue compatible with Zero v0.18. The following has been changed:

  • Ability to pass in TTL parameter to useQuery.
  • Call createSchema without versionnumber.
  • Removal of the #refCountMap in VueView, since the applyChange function with RefCountMap has been deprecated.
  • Replace all the (now deprecated) imports of @rocicorp/zero/advanced with @rocicorp/zero
  • Unittests for useQuery and VueView, based on the tests for Solid.

Notes:

  • The Solid implementation of useQuery has methods to keep track of the RefCount. If I understand v0.1.2 is not compatible with zero 0.17 #48 correctly, we don't need to do anything along those lines from zero 0.18 onwards. Is that correct?
  • We don't test using a (virtual) remote at the moment. This means that the status of a query will always remain unknown. I have commented out the corresponding asserts for now.

Closes:

@socket-security
Copy link

socket-security bot commented Apr 4, 2025

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@rocicorp/zero@0.17.20250307010.18.2025040300 Transitive: eval, filesystem, shell, unsafe +240 63 MB aboodman

View full report↗︎

@arv
Copy link
Collaborator

arv commented Apr 8, 2025

Feel free to add me as a reviewer when you do these things

Copy link
Collaborator

@arv arv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks

@maxstevens-nl
Copy link
Collaborator Author

@arv @danielroe this should be ready to merge now

@danielroe
Copy link
Owner

apologies! please do ping me whenever you want me to see; I don't always get notified when a PR is opened (will need to somehow fix the github notifications 🤔)

@danielroe danielroe changed the title feat: Zero v0.18 feat: upgrade to zero v0.18 Apr 8, 2025
@danielroe danielroe merged commit 95d91ac into danielroe:main Apr 8, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v0.1.2 is not compatible with zero 0.17 Tests for useQuery and VueView

3 participants