From 944545cc5b91c04793749c954d48d44ef7e9c0ef Mon Sep 17 00:00:00 2001 From: Mond Wan Date: Mon, 23 Jan 2017 16:58:19 +0800 Subject: [PATCH] Add a comment about the unit conversion refs #56 --- lib/builder/win.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/builder/win.js b/lib/builder/win.js index 344f7f2..9b303ca 100644 --- a/lib/builder/win.js +++ b/lib/builder/win.js @@ -50,6 +50,9 @@ builder.getResult = function (target, config) { } if (_config.timeout) { + // refs #56: Unit problem + // Our timeout is in second while timeout in window is in milliseconds + // so we need to convert our units accordingly ret = ret.concat([ '-w', util.format('%d', _config.timeout * 1000),