Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Reed-Solomon functions from libfec into gr-satellites #148

Closed
daniestevez opened this issue Aug 8, 2020 · 2 comments
Closed

Move Reed-Solomon functions from libfec into gr-satellites #148

daniestevez opened this issue Aug 8, 2020 · 2 comments
Assignees
@daniestevez
Labels
enhancement

Comments

@daniestevez
Copy link
Owner

Currently gr-satellites requires libfec, as it uses a few of the Reed-Solomon encoding/decoding functions. Eventually, all these functions will appear in GNU Radio (see gnuradio/gnuradio#3657), so that the dependency on libfec can be removed.

Not requiring libfec is good because it is not so easy to build on Windows (see conda-forge/staged-recipes#12274).

Therefore, it makes sense to move this functions from libfec into gr-satellites as a temporary workaround.
@daniestevez daniestevez mentioned this issue Aug 8, 2020
Merged
8 tasks
@daniestevez daniestevez self-assigned this Aug 8, 2020
@daniestevez
Copy link
Owner Author

The changes are now done in 044e28a, which is currently in the remove-libfec branch for testing.

@daniestevez
Copy link
Owner Author

Closing, since this was merged into master in 5d49fea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daniestevez daniestevez

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@daniestevez