New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(eslint-fixes): change eslint to standard and fix warnings #18

Merged
merged 1 commit into from Sep 18, 2017

Conversation

Projects
None yet
2 participants
@lcustodio
Contributor

lcustodio commented Sep 14, 2017

This PR is just a proposition in order to enhance the code practices.

  • Add prettier at dev dependency and as npm task
  • Clean up of eslint conf (avoid conflict between eslint and prettier)
@danilowoz

This comment has been minimized.

Show comment
Hide comment
@danilowoz

danilowoz Sep 14, 2017

Owner

Hi @lcustodio, thanks for your contribution!
Actually I started to use the prettier, you know? BUT I forgot to put the config file inside the project ¬¬

It is like this .prettierrc:

{
  "printWidth": 100,
  "tabWidth": 2,
  "singleQuote": true,
  "trailingComma": "es5",
  "bracketSpacing": true,
  "jsxBracketSameLine": false,
  "parser": "babylon",
  "semi": false
}

Can you add it? What you think?

Owner

danilowoz commented Sep 14, 2017

Hi @lcustodio, thanks for your contribution!
Actually I started to use the prettier, you know? BUT I forgot to put the config file inside the project ¬¬

It is like this .prettierrc:

{
  "printWidth": 100,
  "tabWidth": 2,
  "singleQuote": true,
  "trailingComma": "es5",
  "bracketSpacing": true,
  "jsxBracketSameLine": false,
  "parser": "babylon",
  "semi": false
}

Can you add it? What you think?

@lcustodio

This comment has been minimized.

Show comment
Hide comment
@lcustodio

lcustodio Sep 15, 2017

Contributor

Ah great! Prettier is awesome. 👍

  • add prettier at dev dependency and as npm task
  • clean up of eslint conf (avoid conflict between eslint and prettier)
Contributor

lcustodio commented Sep 15, 2017

Ah great! Prettier is awesome. 👍

  • add prettier at dev dependency and as npm task
  • clean up of eslint conf (avoid conflict between eslint and prettier)
Show outdated Hide outdated package.json
style(eslint-fixes): change eslint to standard and fix warnings
This PR is just a proposition in order to enhance the code practices.

* Eslint configuration changes from 4 to 2.
* Fix warnings about missing `;`.

@danilowoz danilowoz merged commit a400e32 into danilowoz:master Sep 18, 2017

@danilowoz

This comment has been minimized.

Show comment
Hide comment
@danilowoz

danilowoz Sep 18, 2017

Owner

Thanks @lcustodio! Feel free to contribute again! 🍺

Owner

danilowoz commented Sep 18, 2017

Thanks @lcustodio! Feel free to contribute again! 🍺

lcustodio added a commit to lcustodio/react-content-loader that referenced this pull request Sep 18, 2017

chore(lint-tests): lint the tests files
Still related to #18, it may be interesitng to lint the test files to
follow the convention.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment