Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
If
Iends up greater than0xfff, then the memory array can be indexed out-of-bounds (e.g. repeated use of theADD I, Vxinstruction). This is a security vulnerability. A malicious ROM can leverage this to escape the emulator, and execute arbitrary native code on the host system.I noticed this comment in
cpu.h:chip8/src/lib8/cpu.h
Lines 49 to 54 in d952e57
However, this
ADDRESS_MASKconstant is never used anywhere! So, I used it to add masking to all memory reads and writes, fixing the vulnerability.